Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix connection #8963

Merged
merged 6 commits into from
Nov 30, 2024
Merged

chore: fix connection #8963

merged 6 commits into from
Nov 30, 2024

Conversation

kptkin
Copy link
Collaborator

@kptkin kptkin commented Nov 27, 2024

Description

What does the PR do? Include a concise description of the PR contents.

Fix connection logic.

  • I updated CHANGELOG.md, or it's not applicable

Testing

How was this PR tested?

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.00%. Comparing base (2649d9f) to head (a39d6c7).

❗ There is a different number of reports uploaded between BASE (2649d9f) and HEAD (a39d6c7). Click for more details.

HEAD has 43 uploads less than BASE
Flag BASE (2649d9f) HEAD (a39d6c7)
unit 17 1
system 25 0
func 2 0
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           kpt/go-sdk-uuid    #8963       +/-   ##
====================================================
- Coverage            70.23%   49.00%   -21.23%     
====================================================
  Files                  543      165      -378     
  Lines                57657    15279    -42378     
====================================================
- Hits                 40493     7488    -33005     
+ Misses               16466     7219     -9247     
+ Partials               698      572      -126     
Flag Coverage Δ
func ?
system ?
unit 49.00% <ø> (-2.00%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 472 files with indirect coverage changes

@kptkin kptkin marked this pull request as ready for review November 28, 2024 02:16
@kptkin kptkin changed the base branch from kpt/go-sdk-uuid to main November 30, 2024 20:25
@kptkin kptkin merged commit fee44af into main Nov 30, 2024
4 of 17 checks passed
@kptkin kptkin deleted the kpt/go-sdk-fix-connection branch November 30, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants