Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.1.2 has changed API #24

Open
tillea opened this issue May 23, 2018 · 1 comment
Open

Version 1.1.2 has changed API #24

tillea opened this issue May 23, 2018 · 1 comment

Comments

@tillea
Copy link

tillea commented May 23, 2018

Hi,
in Debian we have invented an ABI version 0 to flag once a library has changed its interface. I realised that you have removed some symbols. For instance TrainAndCorrect and ErrorCorrectToTag were removed. For allocate_sequences_from_char only the declaration in SeqLib/BFC.h remained but there is no definition of this function in the C code.
I think it makes sense to introduce an official ABI version to inform programmers about changes. I'll switch the Debian package now to ABI version 1.
Kind regards, Andreas.

@mr-c
Copy link
Contributor

mr-c commented Feb 23, 2020

It also leaks a private _BAM symbol

in 1.1.2 and before it was _ZN6SeqLib4_Bam20open_BAM_for_readingEv@Base a.k.a SeqLib::_Bam::open_BAM_for_reading()@Base
and since then it has changed to
_ZN6SeqLib4_Bam20open_BAM_for_readingENS_10ThreadPoolE@Base a.k.a SeqLib::_Bam::open_BAM_for_reading(SeqLib::ThreadPool)@Base

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants