Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design and specification review of CSS Container Queries Style Features #787

Closed
1 task done
mirisuzanne opened this issue Nov 21, 2022 · 2 comments
Closed
1 task done
Assignees
Labels
Resolution: satisfied The TAG is satisfied with this design Venue: CSS WG

Comments

@mirisuzanne
Copy link

mirisuzanne commented Nov 21, 2022

Wotcher TAG!

I'm requesting a TAG review of Style Features for Container Queries.

TAG guidelines state that custom attributes should not be used for styling, and authors should rely on CSS custom properties instead. However, custom properties are currently limited to carrying a single value, making it hard to achieve any more complex impact beyond simple value substitution. Meanwhile, container queries
allow authors to write conditional CSS based on an ancestor 'container' element. Browsers are already broadly shipping 'dimensional' container queries. By adding the ability to query 'style features' as well, we can use the container query syntax to help solve this long-standing issue for authors.

Further details:

  • I have reviewed the TAG's Web Platform Design Principles
  • Relevant time constraints or deadlines: No specific deadline, but interest in shipping when possible
  • The group where the work on this specification is currently being done: CSSWG
  • The group where standardization of this work is intended to be done (if current group is a community group or other incubation venue): CSSWG
  • Major unresolved issues with or opposition to this specification: No major issues, but some hesitation expressed by implementors around querying non-custom properties
  • This work is being funded by: Google

You should also know that...

There is already a partial (custom properties only) prototype implementation in Chromium v107+ behind the 'experimental web platform features' flag.

We'd prefer the TAG provide feedback as (please delete all but the desired option):

🐛 open issues in our GitHub repo for each point of feedback

( also ok to 💬 leave review feedback as a comment in this issue and @-notify mirisuzanne if that's simpler)

@LeaVerou LeaVerou self-assigned this Nov 21, 2022
@LeaVerou LeaVerou added this to the 2022-11-28-week milestone Nov 21, 2022
@LeaVerou
Copy link
Member

LeaVerou commented Nov 29, 2022

Making this part of container queries circumvents a lot of the issues we faced when we were trying to define a separate conditional rule. Also restricting it to custom properties and equality at first does simplify a host of other hard issues, while addressing a large percentage of use cases. Please make sure that the syntax allows extension in the future (both in terms of querying other properties, as well as querying ranges of values).

I don’t personally see any architectural issues with this, and would be happy to see it move forwards. I do see some smaller design issues and have some questions, for which I will file separate issues in the CSS WG repo.

@LeaVerou
Copy link
Member

We discussed this in a breakout today and we decided my comment above does, in fact, reflect our consensus, so we're gonna go ahead and close this. Thank you for flying TAG! ✈️

@LeaVerou LeaVerou added Resolution: satisfied The TAG is satisfied with this design Venue: CSS WG and removed Progress: untriaged labels Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: satisfied The TAG is satisfied with this design Venue: CSS WG
Projects
None yet
Development

No branches or pull requests

3 participants