Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write WPT to check RTCIceCandidatePair is now an interface #2978

Closed
jan-ivar opened this issue May 30, 2024 · 1 comment · Fixed by #2979
Closed

Write WPT to check RTCIceCandidatePair is now an interface #2978

jan-ivar opened this issue May 30, 2024 · 1 comment · Fixed by #2979
Labels
Needs Test Needs a WPT test

Comments

@jan-ivar
Copy link
Member

From #2961:

this is the kind of PR that updates the IDL fragments on which the idl harness relies: web-platform-tests/wpt#46056

again, the WPT PR would only get generated some days after this WebRTC PR gets merged, so let's not block on it (but instead, let's file an issue when this PR gets merged)

The idl harness will hopefully test window.RTCIceCandidatePair exists, but we should expound on existing WPT webrtc tests to check that what's being returned by UAs are instanceof the right type. cc @sam-vi
@dontcallmedom dontcallmedom added the Needs Test Needs a WPT test label May 30, 2024
@dontcallmedom dontcallmedom mentioned this issue Jun 7, 2024
Merged
dontcallmedom added a commit to dontcallmedom/web-platform-tests that referenced this issue Jun 7, 2024
@dontcallmedom
Add test for RTCIceCandidatePair interface
f5ef804 
see w3c/webrtc-pc#2978
dontcallmedom added a commit to dontcallmedom/web-platform-tests that referenced this issue Jun 7, 2024
@dontcallmedom
Add test for RTCIceCandidatePair interface
77f78da 
see w3c/webrtc-pc#2978
@dontcallmedom dontcallmedom mentioned this issue Jun 7, 2024
Merged
@dontcallmedom
Copy link
Member

I think web-platform-tests/wpt#46655 accomplishes what we need (although without actual implementation, it's a bit hard to verify)

dontcallmedom added a commit that referenced this issue Jun 7, 2024
@dontcallmedom
Add reference to test of interface instance
89e8789 
close #2978
@dontcallmedom dontcallmedom linked a pull request Jun 7, 2024 that will close this issue
Add reference to WPT update for idlharness of icecandidateapair interface #2979
Merged
dontcallmedom added a commit to web-platform-tests/wpt that referenced this issue Jun 13, 2024
@dontcallmedom
Add test for RTCIceCandidatePair interface (#46655)
7b74bc1 
* Add test for RTCIceCandidatePair interface

see w3c/webrtc-pc#2978

* Fix test to wait for ICE connection

per #46655 (review)

* Fix assert name
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Jun 18, 2024
@dontcallmedom @moz-wptsync-bot
Bug 1901218 [wpt PR 46655] - Add test for RTCIceCandidatePair interfa…
660e4df 
…ce, a=testonly

Automatic update from web-platform-tests
Add test for RTCIceCandidatePair interface (#46655)

* Add test for RTCIceCandidatePair interface

see w3c/webrtc-pc#2978

* Fix test to wait for ICE connection

per web-platform-tests/wpt#46655 (review)

* Fix assert name
--

wpt-commits: 7b74bc1d122c2d322329a25e0a6a99a4c2e9583c
wpt-pr: 46655
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Jun 19, 2024
@marco-c
Bug 1901218 [wpt PR 46655] - Add test for RTCIceCandidatePair interfa…
48fb1c5 
…ce, a=testonly

Automatic update from web-platform-tests
Add test for RTCIceCandidatePair interface (#46655)

* Add test for RTCIceCandidatePair interface

see w3c/webrtc-pc#2978

* Fix test to wait for ICE connection

per web-platform-tests/wpt#46655 (review)

* Fix assert name
--

wpt-commits: 7b74bc1d122c2d322329a25e0a6a99a4c2e9583c
wpt-pr: 46655

UltraBlame original commit: 8c6ea51b01dcb2c252fb7e2fc73dc5bdefa2d350
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Jun 19, 2024
@marco-c
Bug 1901218 [wpt PR 46655] - Add test for RTCIceCandidatePair interfa…
629622e 
…ce, a=testonly

Automatic update from web-platform-tests
Add test for RTCIceCandidatePair interface (#46655)

* Add test for RTCIceCandidatePair interface

see w3c/webrtc-pc#2978

* Fix test to wait for ICE connection

per web-platform-tests/wpt#46655 (review)

* Fix assert name
--

wpt-commits: 7b74bc1d122c2d322329a25e0a6a99a4c2e9583c
wpt-pr: 46655

UltraBlame original commit: 8c6ea51b01dcb2c252fb7e2fc73dc5bdefa2d350
i3roly pushed a commit to i3roly/firefox-dynasty that referenced this issue Jun 21, 2024
@dontcallmedom @moz-wptsync-bot
Bug 1901218 [wpt PR 46655] - Add test for RTCIceCandidatePair interfa…
5e7a89d 
…ce, a=testonly

Automatic update from web-platform-tests
Add test for RTCIceCandidatePair interface (#46655)

* Add test for RTCIceCandidatePair interface

see w3c/webrtc-pc#2978

* Fix test to wait for ICE connection

per web-platform-tests/wpt#46655 (review)

* Fix assert name
--

wpt-commits: 7b74bc1d122c2d322329a25e0a6a99a4c2e9583c
wpt-pr: 46655
jamienicol pushed a commit to jamienicol/gecko that referenced this issue Jun 24, 2024
@dontcallmedom @moz-wptsync-bot
Bug 1901218 [wpt PR 46655] - Add test for RTCIceCandidatePair interfa…
327e2bd 
…ce, a=testonly

Automatic update from web-platform-tests
Add test for RTCIceCandidatePair interface (#46655)

* Add test for RTCIceCandidatePair interface

see w3c/webrtc-pc#2978

* Fix test to wait for ICE connection

per web-platform-tests/wpt#46655 (review)

* Fix assert name
--

wpt-commits: 7b74bc1d122c2d322329a25e0a6a99a4c2e9583c
wpt-pr: 46655
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs Test Needs a WPT test
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add reference to WPT update for idlharness of icecandidateapair interface w3c/webrtc-pc
2 participants
@dontcallmedom @jan-ivar