From f00dc9748a479c659529c8133bf6d46b2dc8bf47 Mon Sep 17 00:00:00 2001 From: Dominique Hazael-Massieux Date: Mon, 25 Mar 2024 16:44:14 +0100 Subject: [PATCH 1/6] Use numeric ids everywhere in amendments --- amendments.json | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/amendments.json b/amendments.json index 94b017e70..dc1fe7864 100644 --- a/amendments.json +++ b/amendments.json @@ -13,7 +13,7 @@ ], "type": "correction", "status": "candidate", - "id": "1" + "id": 1 }, { "description": "Allow an implementation-defined limited to the number of configured ICE Servers", @@ -21,7 +21,7 @@ "type": "correction", "status": "candidate", "testUpdates": "not-testable", - "id": "2" + "id": 2 } ], "set-the-configuration": [ @@ -38,7 +38,7 @@ ], "type": "correction", "status": "candidate", - "id": "1" + "id": 1 }, { "description": "Validate ICE transport settings upfront when setting a configuration", @@ -71,7 +71,7 @@ "testUpdates": "already-tested", "type": "correction", "status": "candidate", - "id": "3" + "id": 3 } ], "rtcpeerconnectionstate-description": [ @@ -84,7 +84,7 @@ "testUpdates": "already-tested", "type": "correction", "status": "candidate", - "id": "3" + "id": 3 }, { "description": "Ensure the connecting state happens whenever a ICE or DTLS transport is new ", @@ -97,7 +97,7 @@ ], "type": "correction", "status": "candidate", - "id": "4" + "id": 4 } ], "rtciceconnectionstate-description": [ @@ -110,7 +110,7 @@ "testUpdates": "already-tested", "type": "correction", "status": "candidate", - "id": "3" + "id": 3 } ], "apply-description-restrictions": [ @@ -126,7 +126,7 @@ ], "type": "correction", "status": "candidate", - "id": "5" + "id": 5 } ], "rtccertificateexpiration-dictionary": [ From 0cc9ad86923cabf537af9a4c985899cbd48e8321 Mon Sep 17 00:00:00 2001 From: Dominique Hazael-Massieux Date: Mon, 25 Mar 2024 16:46:09 +0100 Subject: [PATCH 2/6] Renumber amendments mixed up with unrelated others --- amendments.json | 28 ++++++++++++++++++++-------- 1 file changed, 20 insertions(+), 8 deletions(-) diff --git a/amendments.json b/amendments.json index dc1fe7864..e67199018 100644 --- a/amendments.json +++ b/amendments.json @@ -203,7 +203,7 @@ "difftype": "modify", "type": "correction", "status": "candidate", - "id": 23 + "id": 37 } ], "simulcast-functionality": [ @@ -462,7 +462,7 @@ ], "type": "correction", "status": "candidate", - "id": 24 + "id": 13 }, { "description": "Redefine SendCodecs and ReceiveCodecs", @@ -490,10 +490,16 @@ "set-last-stable-offer-properties": [ { "description": "Rollback restores ridless encoding trounced by sRD(simulcastOffer).", + "tests": [ + "webrtc/simulcast/negotiation-encodings.https.html" + ], + "testUpdates": [ + "web-platform-tests/wpt#37477" + ], "pr": 2797, "type": "addition", "status": "candidate", - "id": 24 + "id": 13 } ], "set-rollback-per-transceiver": [ @@ -502,7 +508,13 @@ "pr": 2797, "type": "addition", "status": "candidate", - "id": 24 + "tests": [ + "webrtc/simulcast/negotiation-encodings.https.html" + ], + "testUpdates": [ + "web-platform-tests/wpt#37477" + ], + "id": 13 } ], "apply-remote-description": [ @@ -542,7 +554,7 @@ "difftype": "modify", "type": "correction", "status": "candidate", - "id": 23 + "id": 37 }, { "description": "Remove duplicate rids in proposedSendEncodings.", @@ -619,7 +631,7 @@ "difftype": "modify", "type": "correction", "status": "candidate", - "id": 27 + "id": 43 } ], "simulcast-functionality": [ @@ -791,7 +803,7 @@ "testUpdates": [ "web-platform-tests/wpt#44318" ], - "id": 40 + "id": 42 } ], "setcodecpreferences-receive": [ @@ -806,7 +818,7 @@ "testUpdates": [ "web-platform-tests/wpt#44318" ], - "id": 40 + "id": 42 } ], "create-receiver-algo": [ From 5f047b835ebfd49346e4b7944323450f848f95b2 Mon Sep 17 00:00:00 2001 From: Dominique Hazael-Massieux Date: Mon, 25 Mar 2024 16:46:46 +0100 Subject: [PATCH 3/6] Merge duplictae key in amendments --- amendments.json | 20 +++++++++----------- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/amendments.json b/amendments.json index e67199018..a7e49065b 100644 --- a/amendments.json +++ b/amendments.json @@ -228,6 +228,15 @@ "type": "correction", "status": "candidate", "id": 12 + }, + { + "description": "Update explanation of simulcast envelope.", + "pr": 2814, + "testUpdates": "not-testable", + "difftype": "modify", + "type": "correction", + "status": "candidate", + "id": 28 } ], "webidl-rtcicecandidate": [ @@ -634,17 +643,6 @@ "id": 43 } ], - "simulcast-functionality": [ - { - "description": "Update explanation of simulcast envelope.", - "pr": 2814, - "testUpdates": "not-testable", - "difftype": "modify", - "type": "correction", - "status": "candidate", - "id": 28 - } - ], "rtcrtpcodecparameters": [ { "description": "Create RTCRtpCodec dictionary and reuse in RTCRtpCodecCapability and RTCRtpCodecParameters definitions", From fcb1fafad394f1bdb4ecaea8023405cf19bb387b Mon Sep 17 00:00:00 2001 From: Dominique Hazael-Massieux Date: Mon, 25 Mar 2024 18:12:20 +0100 Subject: [PATCH 4/6] Fix paths to test files --- amendments.json | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/amendments.json b/amendments.json index a7e49065b..97fd92ec1 100644 --- a/amendments.json +++ b/amendments.json @@ -244,7 +244,7 @@ "description": "Add RTCIceCandidate.relayProtocol", "pr": 2763, "tests": [ - "idlharness.https.window.js" + "webrtc/idlharness.https.window.html" ], "testUpdates": [ "web-platform-tests/wpt#36157" @@ -270,7 +270,7 @@ "description": "Add RTCIceCandidate.relayProtocol", "pr": 2763, "tests": [ - "idlharness.https.window.js" + "webrtc/idlharness.https.window.html" ], "testUpdates": [ "web-platform-tests/wpt#36157" @@ -284,7 +284,7 @@ "description": "Add RTCIceCandidate.url", "pr": 2773, "tests": [ - "idlharness.https.window.js" + "webrtc/idlharness.https.window.html" ], "testUpdates": [ "web-platform-tests/wpt#36572" @@ -749,7 +749,7 @@ "description": "Prevent GC of non-closed RTCDataChannels", "pr": 2902, "tests": [ - "webrtc/RTCDataChannel-GC.https.html" + "webrtc/RTCDataChannel-GC.html" ], "testUpdates": [ "web-platform-tests/wpt#43369" @@ -766,7 +766,7 @@ "type": "correction", "status": "candidate", "tests": [ - "webrtc/RTCDataChannel-binaryType.window.js" + "webrtc/RTCDataChannel-binaryType.window.html" ], "testUpdates": [ "web-platform-tests/wpt#41663" @@ -779,7 +779,7 @@ "type": "correction", "status": "candidate", "tests": [ - "webrtc/RTCDataChannel-binaryType.window.js", + "webrtc/RTCDataChannel-binaryType.window.html", "webrtc/RTCDataChannel-send.html", "webrtc/RTCPeerConnection-createDataChannel.html" ], From 0347d6114cde0b19db5905d973b423f87680ae6e Mon Sep 17 00:00:00 2001 From: Dominique Hazael-Massieux Date: Mon, 25 Mar 2024 18:34:32 +0100 Subject: [PATCH 5/6] Add links to relevant WPT PRs from amendments list Help with reviews of the amendments --- amendments.js | 22 +++++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/amendments.js b/amendments.js index 05db3db7d..00c67df08 100644 --- a/amendments.js +++ b/amendments.js @@ -58,6 +58,25 @@ function listPRs(pr) { return span; } +function listTestUpdates(updates) { + const s = document.createElement("span"); + if (updates === "not-testable") { + s.textContent = " (not testable)"; + } else if (updates === "already-tested") { + s.textContent = " (no change needed in tests)"; + } else if (Array.isArray(updates)) { + s.textContent = " - Changes to Web Platform Tests: "; + updates.forEach(u => { + const link = document.createElement("a"); + link.href = "https://github.com/web-platform-tests/wpt/pull/" + u.split("#")[1]; + link.textContent = "#" + u.split("#")[1]; + s.append(link); + s.append(" "); + }); + } + return s; +} + const capitalize = s => s[0].toUpperCase() + s.slice(1); async function listAmendments() { @@ -104,7 +123,7 @@ async function listAmendments() { const li = document.createElement("li"); const entriesUl = document.createElement("ul"); li.appendChild(document.createTextNode(`${capitalize(status)} ${capitalize(type)} ${id}: `)); - amendment.forEach(({description, section, pr}, i) => { + amendment.forEach(({description, section, pr, testUpdates}, i) => { const entryLi = document.createElement("li"); entryLi.innerHTML = description; const link = document.createElement("a"); @@ -113,6 +132,7 @@ async function listAmendments() { link.textContent = `section ${titleFromId(section)}`; entryLi.appendChild(link); entryLi.appendChild(listPRs(pr)); + entryLi.appendChild(listTestUpdates(testUpdates)); entriesUl.appendChild(entryLi); }); li.appendChild(entriesUl); From cd51e8bffab737825aa210a45f40a376677cc108 Mon Sep 17 00:00:00 2001 From: Dominique Hazael-Massieux Date: Mon, 25 Mar 2024 18:35:06 +0100 Subject: [PATCH 6/6] Remove unexplained and annoying css rule on spans --- webrtc.css | 2 -- 1 file changed, 2 deletions(-) diff --git a/webrtc.css b/webrtc.css index a4826ee5d..c43f126c7 100644 --- a/webrtc.css +++ b/webrtc.css @@ -22,8 +22,6 @@ body ins, body del { display: block; } body * ins, body * del { display: inline; } -li > span:not([title=""]):not([class="XXX"]):not([class="impl"]):not([class="note"]) { border-bottom: solid #99CC99; } - .note { color: green; background: transparent; font-family: sans-serif, Droid Sans Fallback; } .warning { color: red; background: transparent; } .note, .warning { font-weight: bolder; font-style: italic; }