-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Touch Events term "expose legacy touch event APIs" not included #560
Comments
I guess filing this issue fixed it, because now it's there: https://github.com/w3c/webref/blob/main/ed/dfns/touch-events.json#L1266 The build still fails, but maybe it needs some more time for the terms to flow through to the bikeshed build server. |
Is it possible to shorten the time it takes for terms to flow through? |
It's here but note access is
As far as I know, Bikeshed does not use webref data yet, so there's not much we can do from a webref perspective...
That's being tracked in #486 but see above, that probably won't help you in this case... |
I responded quickly in-between calls, but now that I had a bit of time to look into it, it seems that the Edit: I prepared w3c/touch-events#114 to switch the spec to the right profile. I confirm that the term would then correctly be flagged as "exported". |
The spec referenced an outdated profile of ReSpec. Some editing features were not supported as a result. Also see: w3c/webref#560 (comment)
Thanks @tidoust! |
@tabatkins what is needed for bikeshed to pick up the new term? |
I'll let Tab correct me but unless something changed in Bikeshed recently, adding the spec to the list of specs that Bikeshed knows about is not going to be enough. Bikeshed won't see definitions in this spec because the spec is generated on-the-fly when it is loaded (that's how ReSpec works). A possible workaround is to rather publish the generated version of the spec under https://w3c.github.io/touch-events/ and not the source file. This can be done with the spec-prod GitHub action. I'd be happy to prepare another PR against the w3c/touch-events repository to add that generation step if you think that's useful (the job would run whenever a commit is pushed to the default branch). Another option to tell Bikeshed about these definitions is to add them directly as custom definitions in the DOM spec. The spec already contains a custom definition for the |
With ReSpec specs, it depends on how the markup is done. So long as the dfn contract is satisfied in the source code, Bikeshed can pick it up. In this case, as it's a plain term definition, everything's already golden (all the defaults are correct) except for the export, and even if it's not exported in the source that can be fixed by adding it to link-defaults in the spec that's using it; there's no need for a custom definition. (There almost never is; most custom definitions are cargo-culted.) The other thing needed is for the spec to be in Shepherd, which it currently isn't; I've just added it, so we'll just need to wait for the bot to cycle, which usually takes an hour or so. |
Thanks for the help! The definition uses |
I don't know what class=export does, except possibly put the data-export attribute on it in the processed document? |
Using Inspect Element for https://w3c.github.io/touch-events/#conditionally-exposing-legacy-touch-event-apis it's still |
See previous comment. The PR I prepared needs to be merged: w3c/touch-events#114 Once that is done, ReSpec will produce a You may put |
The spec referenced an outdated profile of ReSpec. Some editing features were not supported as a result. Also see: w3c/webref#560 (comment)
Closing this issue following spec update earlier today. Definition is now correctly flagged as "public" in Webref data and available in ReSpec's xref database. Availability in Bikeshed is a different matter and either requires the spec's generation workflow, the spec's source, or integrating Webref data in Bikeshed. |
Thanks @tidoust ! |
w3c/touch-events#113 was merged yesterday, I had hoped it would fix the build error in whatwg/dom#1071 but it seems not. The term "expose legacy touch event APIs" not included in webref. Per https://respec.org/docs/#data-export I think
<dfn class="export">
is the correct incarnation.https://github.com/w3c/webref/blob/main/ed/dfns/touch-events.json was updated 5 days ago, but the latest reffy run was run more recently.
What's wrong?
The text was updated successfully, but these errors were encountered: