Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase maximum number of items on paginated results #48

Closed
vivienlacourba opened this issue Oct 7, 2015 · 1 comment
Closed

Increase maximum number of items on paginated results #48

vivienlacourba opened this issue Oct 7, 2015 · 1 comment
Assignees
@jean-gui
Labels
enhancement

Comments

@vivienlacourba
Copy link
Member

We got several requests asking to increase the number of items per page (some people even asked us to get rid of pagination, see issue #46 from @sandhawke).

While it does not seem feasible to completely remove pagination (as we already experience it when we reached memory limits), we should be able to increase the current maximum which is at 100 to an higher number. That number would be determined by testing our various endpoints, and also tuning of PHP's max memory setting.

Additionally this would reduce the number of request to retrieve a full list of results, which would be a performance increase for users that are not local to MIT.
@jean-gui
Copy link
Contributor

jean-gui commented Oct 7, 2015

Maximum increased to 1000, and default is now 100.

@jean-gui jean-gui closed this as completed Oct 7, 2015
vivienlacourba added a commit that referenced this issue Oct 7, 2015
@vivienlacourba
Pagination now accept more items
19a6198 
The new default items per page is 100 (was 50).
The new max items per page is 1000 (was 100).

See: #48
@vivienlacourba vivienlacourba mentioned this issue Oct 7, 2015
Closed
jean-gui added a commit that referenced this issue Oct 8, 2015
@jean-gui
#48 Increased default hit limit to 5000
5c33ce7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jean-gui jean-gui

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jean-gui @vivienlacourba