Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Candidate/Proposed changes markup #1077

Closed
plehegar opened this issue Dec 18, 2020 · 6 comments · Fixed by #1079
Closed

Candidate/Proposed changes markup #1077

plehegar opened this issue Dec 18, 2020 · 6 comments · Fixed by #1079
Assignees

Comments

@plehegar
Copy link
Member

The T style sheet was adjusted as well:
[[

    • .correction for "candidate corrections" (div, aside, details, section)
    • .addition for "candidate additions" (div, aside, details, section)
    • .correction.proposed for "proposed corrections" (div, aside, details, section)

We should reflect those CSS classes (without bounding them to specific HTML elements for forward compat) in:
https://github.com/w3c/specberus/blob/main/lib/rules/sotd/rec-addition.js

This is related to w3c/csswg-drafts#5807

@plehegar
Copy link
Member Author

To be clear, unless .correction.proposed and .addition.proposed appear in the document, we should require only require
the SOTD text: "This document was published by the @@ Working Group as a Recommendation."

@jennyliang220
Copy link
Contributor

jennyliang220 commented Dec 19, 2020

New Rules

Type candidate corrections proposed corrections candidate additions proposed additions no change
Class .correction .correction.proposed .addition .addition.proposed
Text Candidate corrections are marked in the document. Proposed corrections are marked in the document. Candidate additions are marked in the document. Proposed additions are marked in the document.
SOTD This document was published by the @@ Working Group as a Recommendation. It includes candidate corrections. This document was published by the @@ Working Group as a Recommendation. It includes proposed corrections. This document was published by the @@ Working Group as a Recommendation. It includes candidate additions, introducing new features since the previous Recommendation. This document was published by the @@ Working Group as a Recommendation. It includes proposed additions, introducing new features since the previous Recommendation. This document was published by the @@ Working Group as a Recommendation.

This document does not contain any candidate or proposed changes.

In addtion to the table above, for document with both proposed corrections and proposed additions, SOTD would be:

This document was published by the @@ Working Group as a Recommendation. It includes proposed change(s)?, introducing substantive change(s)? and new feature(s)? since the previous Recommendation.

Question

1. Not bounding HTML

without bounding them to specific HTML elements for forward compat

@plehegar just to be clear, does it mean the Text for HTML element doesn't has to be 'Candidate corrections are marked in the document.'?

Answer: It means the HTML elements can be p, span, div or anything else.

2. SOTD paragraph

To be clear, unless .correction.proposed and .addition.proposed appear in the document, we should require only require the SOTD text: "This document was published by the @@ Working Group as a Recommendation."

Should Pubrules allows more sentences after "published by ... as a Recommendation.''?

e.g. "If you wish to make comments regarding this document, please send them to..."

<p>
This document was published by the <a href="@@WG homepage@@">Foobar Working Group</a> as a Recommendation. If you wish to make comments regarding this document, please send them to
<a href="mailto:[email protected]">[email protected]</a> (<a href="mailto:[email protected]?subject=subscribe">subscribe</a>,
<a href="https://lists.w3.org/Archives/Public/mailinglist-comments/">archives</a>). All comments are welcome.
<!-- substantiveChanges: true, newFeatures: true -->
It includes <a href="https://www.w3.org/2020/Process-20200915/#proposed-changes">proposed changes</a>,
introducing substantive changes and new features since the Previous Recommendation.
</p>

Answer: Yes, there can be more sentences.

@jennyliang220
Copy link
Contributor

@plehegar any idea when will https://github.com/w3c/tr-design/tree/gh-pages/p2020mockup have the mockups? So that specberus can start implementing it.

@svgeesus
Copy link
Contributor

This is presumably the cause of #1312

@svgeesus
Copy link
Contributor

@plehegar @jennyliang220 should I just note an open specberus bug and send a publication request anyway?

@plehegar
Copy link
Member Author

I added mockups for candidate changes w3c/tr-design#244

deniak pushed a commit that referenced this issue Aug 19, 2021
* if no proposed changes, sentence publish shall have no following text. implement #1077 (comment)

* add candidate changes for REC

* add .proposed class for REC

* add test for publish.js for candidation corrections. Add rec-addition check

* finish check for re-addition.js

* change document

* change document
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants