-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Candidate/Proposed changes markup #1077
Comments
To be clear, unless .correction.proposed and .addition.proposed appear in the document, we should require only require |
New Rules
In addtion to the table above, for document with both proposed corrections and proposed additions, SOTD would be:
Question1. Not bounding HTML
@plehegar just to be clear, does it mean the Text for HTML element doesn't has to be 'Candidate corrections are marked in the document.'? Answer: It means the HTML elements can be 2. SOTD paragraph
Should Pubrules allows more sentences after "published by ... as a Recommendation.''? e.g. "If you wish to make comments regarding this document, please send them to..." specberus/test/docs/sotd/rec-obsl.html Lines 63 to 70 in 5405a04
Answer: Yes, there can be more sentences. |
@plehegar any idea when will https://github.com/w3c/tr-design/tree/gh-pages/p2020mockup have the mockups? So that specberus can start implementing it. |
This is presumably the cause of #1312 |
@plehegar @jennyliang220 should I just note an open specberus bug and send a publication request anyway? |
I added mockups for candidate changes w3c/tr-design#244 |
* if no proposed changes, sentence publish shall have no following text. implement #1077 (comment) * add candidate changes for REC * add .proposed class for REC * add test for publish.js for candidation corrections. Add rec-addition check * finish check for re-addition.js * change document * change document
The T style sheet was adjusted as well:
[[
]]
https://www.w3.org/StyleSheets/TR/2016/base.css
We should reflect those CSS classes (without bounding them to specific HTML elements for forward compat) in:
https://github.com/w3c/specberus/blob/main/lib/rules/sotd/rec-addition.js
This is related to w3c/csswg-drafts#5807
The text was updated successfully, but these errors were encountered: