-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testability of normative DID Spec Registries statement on metadata #65
Comments
Correct.
Yes, agreed.
It is human testable. A human can check to see if "All metadata property definitions registered in the DID Specification Registries [DID-SPEC-REGISTRIES] define the value type, including any additional formats or restrictions to that value (for example, a string formatted as a date or as a decimal integer)." I suggest we do the second option (if we don't have to go through another CR to do it), or just flag the statement as human testable and not something the WG intended to test. We have lots of these sorts of statements in the DID Methods section. |
Fully agreed.
I will review them. |
When I look for the word From the point of view of completeness of the test, and also for creation of a report, I think it is better to include human testable statements in the test suite as a For example, in Section 5.2. Verification Method, the following statements are missing as test statements.
In Section 5.3:
In Section 5.4:
etc. |
At this point, this isn't done, and is unlikely to be done before the cut off on Tuesday. I suggest we don't do this (or could do it later). Take a look at issue #72 - #76 -- we are just not adding marks to the checkboxes that are associated the human-readable tests during the audit. |
@msporny thanks. I understand the plan. From the consistency point of view, do you want to me to remove the human testable statements (currently marked |
Yes, at this point we should just remove all .todo() statements from the test suite. I don't think they're being used by anyone. |
As discussed in w3c#65, removed `todo` for the following statement: 7.3 Metadata Structure - All metadata property definitions registered in the DID Specification Registries [DID-SPEC-REGISTRIES] MUST define the value type, including any additional formats or restrictions to that value (for example, a string formatted as a date or as a decimal integer).
@msporny Created a PR for 7.3. Found that the following in is still a todo in
|
As discussed in #65, removed `todo` for the following statement: 7.3 Metadata Structure - All metadata property definitions registered in the DID Specification Registries [DID-SPEC-REGISTRIES] MUST define the value type, including any additional formats or restrictions to that value (for example, a string formatted as a date or as a decimal integer).
@shigeya wrote:
Let me quote the statement again here:
From the core spec point of view, the above statement is not testable within the core spec. This spec text needs to be placed in DID-SPEC-REGISTRIES, not within core spec. I honestly have no idea whether we can treat this statement as "human testable."
From a different perspective: since the current test implementation runs the whole test against the transcript of interaction with multiple method implementations, it is desirable to test properties defined in DID-SPEC-REGISTRIES. In this case, we need a machine-readable -- at least partial -- DID-SPEC-REGISTRY.
I think there are three options:
It is possible to create an optional configuration parameter that may hold machine-readable (possibly partial) DID-SPEC-REGISTRIES, which can be usable for the above option 3.
(Note: due to schedule conflict, I can't attend the special topic call this week)
The text was updated successfully, but these errors were encountered: