Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scanning of implementation directory and test suites selection #136

Open
shigeya opened this issue May 27, 2021 · 3 comments
Open

Scanning of implementation directory and test suites selection #136

shigeya opened this issue May 27, 2021 · 3 comments

Comments

@shigeya
Copy link
Contributor

shigeya commented May 27, 2021

@msporny:

Just as an aside: @OR13 @shigeya @peacekeeper -- we really should make the default.js files scan the implementations directory and pull in files that contain certain content instead of having people list them by hand in default.js -- the majority of our merge conflicts are because of the default.js files. We probably shouldn't do the change now 'cause of all the PRs coming in... but perhaps when the dust settles a bit.

Originally posted by @msporny in #127 (comment)

If we want to implement this, each of the implementation JSON objects needs a property with the name supported_suites or suites which is an array of the name of the test suites the data supports.

@shigeya shigeya changed the title Scanning of implementation directory and suites selection Scanning of implementation directory and test suites selection May 27, 2021
@OR13
Copy link
Contributor

OR13 commented Jun 1, 2021

@msporny
Copy link
Member

msporny commented Jun 1, 2021

If we want to implement this, each of the implementation JSON objects needs a property with the name supported_suites or suites which is an array of the name of the test suites the data supports.

OR, we could detect the type of implementation file it is... there are really only two: DID Methods and Resolvers, and each have their own special fields we could auto-detect. No need to put burden on implementers when we don't have to.

@OR13
Copy link
Contributor

OR13 commented Jun 1, 2021

Imo, we ought to detect the type, and automatically build the collection from files in folders... least friction for developers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants