-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistency on implementation JSON's properties needed for report generation #132
Comments
I suggest we solve this by injecting defaults when they are not present. and use the following defaults:
and then we can incrementally replace UNKNOWNs with reasonable values. |
For the Universal Resolver reports, we always just use the string "Universal Resolver" as the "implementation" field (e.g. see here). @BernhardFuchs maybe we should update our Universal Resolver reports to also include the DID method name in the "implementation" field, e.g. to say something like "Universal Resolver - did:example" |
@peacekeeper I will probably make |
@shigeya We could easily add the property Question is in which format the value should be:
or any other idea? |
Thank you.
I think |
For report generating purposes, we need to have at least:
Some of the JSON lacks
didMethod
.A few thoughts.
implementer
and the submitter's contact, maybe GitHub user id. I think it is not wise to bury GitHub user id into descriptive texts.Implementation
is a descriptive text. Some of them using the GitHub path; some of them include descriptive texts. Since this will appear as part of the test report, we may need to adjust texts to make the generated tables consistent.The text was updated successfully, but these errors were encountered: