openvpn: Add peer fingerprint mode #1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebortg
requested changes
Sep 11, 2023
| set interfaces openvpn vtun1 remote-address '10.255.1.1' | ||
|
|
||
| Remote Configuration - Annotated: | ||
| set interfaces openvpn vtun1 shared-secret-key openvpn-1 # Locally generated secret name |
There was a problem hiding this comment.
should this line deleted, if this is a cert based s2s vpn? (also on the remote site config)
and is
set tls certificate 'openvpn-local'
set tls certificate 'openvpn-remote'
missing?
There was a problem hiding this comment.
Oh, right, those were missing, thanks!
dmbaturin
force-pushed
the
T5270-openvpn-peer-fingerprint
branch
from
9bda306
to
14633c9
Compare
jestabro
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since pre-shared keys are deprecated, we need to document the migration path.