Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

Allow to customize font family #79

Open
bongnv opened this issue Apr 22, 2020 · 3 comments
Open

Allow to customize font family #79

bongnv opened this issue Apr 22, 2020 · 3 comments
Labels

Comments

@bongnv
Copy link

bongnv commented Apr 22, 2020

Feature request

What problem does this feature solve?

Currently, font-family in some places is hard-coded to PT Serif, Serif. Therefore, if you want to use a different font for your own need, it's not possible unless:

I believe both of the approaches are not elegant.

What does the proposed API look like?

Allow to override $font-family-serif in index.styl or palette.styl like:

$font-family-serif = 'Noto Serif', Serif

How should this be implemented in your opinion?

Some hard-coded place like:

.vuepress-blog-theme-content
  font-family PT Serif, Serif

will be changed to

.vuepress-blog-theme-content
  font-family $font-family-serif

Are you willing to work on this yourself?

Yes

@billyyyyy3320
Copy link
Member

Yes, there're still some styles should be able to override in both default theme and blog theme.

I think the variable name can be $fontFamily. Contribution Welcome!

@Kocal
Copy link
Contributor

Kocal commented Apr 22, 2020

I am probably missing something, but how can we override font.style and prevent font files import?

I'm also looking for this new feature :D

@bongnv
Copy link
Author

bongnv commented Apr 23, 2020

Raised the PR #80.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants