-
-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ts path mapping between packages #395
Conversation
Before that, when ctrl clicking the package @posva/vuefire-core inside another package files, it redirected to the dist folder. Now it goes to the src.
For some reason, it complains about files not being included when testing, but all |
Codecov Report
@@ Coverage Diff @@
## master #395 +/- ##
=======================================
Coverage 99.72% 99.72%
=======================================
Files 14 14
Lines 368 368
Branches 64 64
=======================================
Hits 367 367
Misses 1 1 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the best would be to test on IE and see if things are still working |
I think that in the future Vuefire should just be in one single package. This would remove so many existing problems we have with tooling... |
I think that makes sense, but would vuexfire be distributed in the same package too? |
yeah, everything in one tree-shakable package |
Thank you for this and sorry I never camke back to you @trickstival |
What does this PR contain?
It just changes the
@posva
packages path to be mapped to the src instead of the declaration files generated by the build in thedist
folder.Before that, when ctrl clicking the package
@posva/vuefire-core
inside another package files, itredirected to the dist folder. Now it goes to the src.
I also removed one import that was pointing to a dist folder inside the core package (idk why it was doing that).
Motivation
It was really frustrating to look after the core files while debugging and end up in a declaration file. This should make the code flow easier to understand by ctrl clicking.
Edit:
I noticed that #384 should have its problem fixed too