Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript error for close action inside slot #432

Open
liyasthomas opened this issue Feb 21, 2024 · 1 comment
Open

Typescript error for close action inside slot #432

liyasthomas opened this issue Feb 21, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@liyasthomas
Copy link

liyasthomas commented Feb 21, 2024

Version

vue-final-modal: v4.5.4
vue: v3.4.19

OS

Mac

Reproduction Link

Screenshot 2024-02-21 at 9 06 52 PM

Steps to reproduce

Inspired by #430 I tried to implement close action in the default slot but ended up getting the below typescript error:

Property 'close' does not exist on type '((props: { close: () => void; }) => void) | undefined'.ts

The close actions work fine, it's just the typescript issue persisting on usage.

What is Expected?

Close slot action should be typesafe.

What is actually happening?

Typescript compiler throwing error on usage.

@liyasthomas liyasthomas added the bug Something isn't working label Feb 21, 2024
@Adizbek
Copy link

Adizbek commented Nov 19, 2024

This problem still exists

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants