-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Problem uploading GIF images to Storefront #20
Comments
@brunojdo Had told me that they're not going to allow GIF's, it's vtex.file-manager-graphql that strips the frames from the file, because GIF's are very large and would negatively impact the website performance. I already have an issue with the same discussion vtex-apps/file-manager-graphql#4 Workarounds for now could be to use rich-text or sandbox, but that doesn't work for all cases (like carousel) |
I think this approach is too aggressive, a lot of big e-commerce use gifs as medium type. For example Americanas.com, Dafiti: This image above only has ~100kb. I don't know if the market is prepared to this mindset, maybe it should be considered in a future release as a Major of the StoreFront, allowing stores to migrate to this new paradigm after it's mature enough. |
Maybe the solution is limit the file update maximum size more than block gifs |
I think we should accept GIFs as upload files and transform them to mp4 or WebM in our backend. As suggested here: https://web.dev/replace-gifs-with-videos |
We do have a way of displaying GIFs in the store, although not recommended nowadays for performance issues, like pointed previously. You guys could use the Image component and use the src prop to point to a gif image. |
Fixed some time ago |
Describe the bug
GIF images are loosing animation when uploaded to Storefront
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Uploading animated GIFs should retain animation data;
The text was updated successfully, but these errors were encountered: