Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private queries #110

Open
athoscouto opened this issue Sep 22, 2021 · 1 comment
Open

Private queries #110

athoscouto opened this issue Sep 22, 2021 · 1 comment
Labels
question Further information is requested

Comments

@athoscouto
Copy link
Contributor

What are you trying to accomplish? Please describe.
I'm trying to understand why most (if not all) queries from this app are annotated with @cacheControl(scope: PRIVATE).

My understanding is that fetched reviews shouldn't vary by user and therefore they can be cached.
When we use PRIVATE as the scope we make all queries to be executed as POST requests, which make them bypass all platform caches.

Since there is no cache, reviews and ratings account for 15~20% of our ingress requests. To make matters worse, the app has a leak which makes it overuse resources and become unstable. And when the app fails, our border error rate increases, which:

  • Triggers false alarms that overload platform on-call engineer.
  • Opens our ingress circuit breaker, making the cluster as a whole unstable.

I understand that it may not be trivial to debug the leak, but if caching responses is an option it may reduce the app load to the point where the leak is not relevant and instabilities do not hamper the whole platform.

Additional info

@athoscouto athoscouto added the question Further information is requested label Sep 22, 2021
@athoscouto
Copy link
Contributor Author

@vtex-apps/us-1st-party-apps @icazevedo would appreciate your input here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant