Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty deliveryOptions when multiple sellers are involved in a cart and supplying different delivery names #195

Open
bdudabeecoded opened this issue Mar 30, 2024 · 0 comments

Comments

@bdudabeecoded
Copy link

bdudabeecoded commented Mar 30, 2024

OrderForm -> shipping -> deliveryOptions is always an empty array when:

  • marketplace scenario with more than one seller is involved in the cart (items from multiple sellers)
  • at least one seller has a delivery sla name which is unique

Seems that the assumption in node/utils/address.ts:16 filterDeliveryOptions by the condition deliveryOptionIsInEveryLogisticsInfo is not correct when multiple sellers are involved in the cart. It might be correct when applied per seller when multiple deliveries are created for a seller order (e.g. when package weight is over the max allowed per shipping policy), but may not be correct when multiple products from the same seller but with different transport modals are in the cart -> the delivery names will most probably differ.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant