From 9b6b770dd77095e0686e8fa8d37008a170bed715 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9gis=20Behmo?= Date: Thu, 3 Jun 2021 17:57:04 +0200 Subject: [PATCH] feat: better object creation in "k8s start" When running "tutor k8s start", it's unnecessary to attempt to create volumes and namespace multiple times. --- CHANGELOG.md | 2 ++ tutor/commands/k8s.py | 3 +-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 762df07b01..b0dd4ba00c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,8 @@ Note: Breaking changes between versions are indicated by "💥". ## Unreleased +- [Improvement] Better Kubernetes object creation. + ## v11.3.0 (2021-05-18) - 💥[Security] Disable python-evaluated input by default as we don't run codejail. diff --git a/tutor/commands/k8s.py b/tutor/commands/k8s.py index 7b03e05308..0e0c3b2cc3 100644 --- a/tutor/commands/k8s.py +++ b/tutor/commands/k8s.py @@ -239,8 +239,7 @@ def start(context: Context) -> None: "--kustomize", tutor_env.pathjoin(context.root), "--selector", - # Here use `notin (job, xxx)` when there are other components to ignore - "app.kubernetes.io/component!=job", + "app.kubernetes.io/component notin (job,volume,namespace)", )