Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MeaMod implementation ignores answers that include SRV records #58

Open
ImUrX opened this issue Mar 12, 2024 · 0 comments · May be fixed by #59
Open

MeaMod implementation ignores answers that include SRV records #58

ImUrX opened this issue Mar 12, 2024 · 0 comments · May be fixed by #59

Comments

@ImUrX
Copy link

ImUrX commented Mar 12, 2024

vrc-oscquery-lib/vrc-oscquery-lib/Zeroconf/MeaModDiscovery.cs

Lines 110 to 116 in 88991a3

foreach (SRVRecord record in response.AdditionalRecords.OfType<SRVRecord>())
{
if (record.TTL == TimeSpan.Zero)
RemoveMatchedService(record);
else
AddMatchedService(response, record);
}

As the current implementation only makes a lookup in the additional records list, it won't find the SRV record if it was sent inside the answers section. This is correctly detected by other DNS-SD implementations (Avahi, Bonjour, FindDevice) and JmDNS which is used very broadly in OpenHAB.
@ImUrX ImUrX linked a pull request Mar 12, 2024 that will close this issue
Open
dfgHiatus added a commit to dfgHiatus/vrc-oscquery-lib that referenced this issue Dec 4, 2024
@dfgHiatus
(tweak) Merge SlimeVR fix
e2aade3 
vrchat-community#58

vrchat-community#59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Also check Answers for records ImUrX/vrc-oscquery-lib
1 participant
@ImUrX