Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodejs::repo::nodesource::baseurl and source_baseurl override #359

Open
cdenneen opened this issue Feb 22, 2018 · 2 comments
Open

nodejs::repo::nodesource::baseurl and source_baseurl override #359

cdenneen opened this issue Feb 22, 2018 · 2 comments
Labels
enhancement New feature or request

Comments

@cdenneen
Copy link

Allowing for mirrors this needs the ability to override.

Having to do something like this is really bad:

Yumrepo<| title == 'nodesource' |> { baseurl = "https://mirror...."}
Yumrepo<| title == 'nodesource-source' |> { baseurl = "https://mirror...."}

@juniorsysadmin juniorsysadmin added enhancement New feature or request needs-feedback Further information is requested labels Feb 22, 2018
@juniorsysadmin
Copy link
Member

@cdenneen Hmmm, with this type of use case I think the better and cleaner alternative is to manage the yumrepo resource yourself using the $repo_class parameter. This kind of approach is more or less consistent with how upstream repository configuration is included with modules elsewhere. If you're using a virtual repository manager like Nexus, Artifactory etc or simply want to manage repositories outside of this module setting $manage_package_repo to false is an option as well.

@cdenneen
Copy link
Author

There are many packages that allow for the prefix to be supplied for example:
https://github.com/sensu/sensu-puppet/blob/master/manifests/init.pp#L447

This allows for you to setup an internal mirror of the external resource but allows for the "suffix" naming changes as needed by the module to account for upstream to continue to work as expected.

I can have it unmanage the repo and do outside the class but it would be useful to have as parameter.

@juniorsysadmin juniorsysadmin removed the needs-feedback Further information is requested label Mar 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants