Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failing test case for issue #1 #2

Open
voltrevo opened this issue Mar 8, 2023 · 0 comments
Open

Add failing test case for issue #1 #2

voltrevo opened this issue Mar 8, 2023 · 0 comments
Labels
good first issue Good for newcomers

Comments

@voltrevo
Copy link
Owner

voltrevo commented Mar 8, 2023

#1 demonstrates a program which behaves incorrectly.

Solving this wouldn't be a good first issue, but adding a failing test case for it is.

All you have to do is add a file like this: https://github.com/voltrevo/ValueScript/blob/main/inputs/failing/assignmentEvalOrder.ts. (To be clear, test_output! is the incorrect version that is currently produced, not what the output should be. Instead, just comment below about what it should be instead.)

There's a github action to run the tests, so you don't even need to run this locally to validate it :).

@mlajtos (others welcome too)

@voltrevo voltrevo added the good first issue Good for newcomers label Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant