Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T017: Website rendering is incorrect #141

Closed
dominiquesydow opened this issue Sep 9, 2021 · 5 comments · Fixed by #157
Closed

T017: Website rendering is incorrect #141

dominiquesydow opened this issue Sep 9, 2021 · 5 comments · Fixed by #157
Assignees
Labels
bug Something isn't working

Comments

@dominiquesydow
Copy link
Collaborator

dominiquesydow commented Sep 9, 2021

The rendering of T017 (and only T017) is off on our website
https://projects.volkamerlab.org/teachopencadd/talktorials/T017_advanced_nglview_usage.html#Practical

Maybe this is related to saved widget states (though we do save them in other notebooks, too).

Let's wait a few days and check in again if the problem is still there.

@dominiquesydow dominiquesydow self-assigned this Sep 9, 2021
@hainm
Copy link

hainm commented Sep 15, 2021

@dominiquesydow

The rendering of T017 (and only T017) is off on our website

May be: nglviewer/nglview#889

and FYI: Using view.gui_style = 'ngl' might mess up your website's font: nglviewer/nglview#988

By the ways, great nglview tutorials. Thanks.

@gph82
Copy link

gph82 commented Sep 21, 2021

Hi, I think these are indeed related nglviewer/nglview#988. @dominiquesydow it'd be great if you manage to solve this!

@dominiquesydow
Copy link
Collaborator Author

Hi @hainm,

Thanks a lot for your pointers!

The rendering of T017 (and only T017) is off on our website

May be: nglviewer/nglview#889

I have to admit that I do not understand how this issue could be linked to ours.
At least it seems like we do not have a problem with displaying the view inside notebooks.

and FYI: Using view.gui_style = 'ngl' might mess up your website's font: nglviewer/nglview#988

That did the trick indeed, thank you! I have commented the respective cells now and we show only a screenshot of the NGL GUI as outlined in PR #157

By the ways, great nglview tutorials. Thanks.

Thanks a lot! And thanks to you for creating and maintaining such an amazing tool!

@dominiquesydow
Copy link
Collaborator Author

Hi, I think these are indeed related nglviewer/nglview#988. @dominiquesydow it'd be great if you manage to solve this!

Hi @gph82, thanks a lot for the detailed GH issue of yours. I am out of my depth here as well but at least your description helped us to find a workaround for TeachOpenCADD, thanks!

@hainm
Copy link

hainm commented Oct 26, 2021

I have to admit that I do not understand how this issue could be linked to ours.
At least it seems like we do not have a problem with displaying the view inside notebooks.

Then this is great. Previous user got broken displays for some if displaying too many views in a single notebook.

@dominiquesydow dominiquesydow linked a pull request Oct 26, 2021 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants