support for old GTK+ version

[NaWer]

On Ubuntu 14.04 :

(mark-my-words:19654): Gtk-ERROR **: failed to add UI: <resource>/com/voldyman/markmywords/ui/headerbar.ui: required gtk+ version 3.12, current version is 3.10

[voldyman]

can you build and verify that the branch gtk-3.10 works for you? if so then i will pull it into the master branch

[NaWer]

I've tried with version="3.10" :

 (mark-my-words:24933): Gtk-ERROR **: failed to add UI: <resource>/com/voldyman/markmywords/ui/headerbar.ui:2:217 <object> requires attribute "id"

[NaWer]

Fixed here : #64
Maybe you want to change id before merging ;)

[voldyman]

can you apply this diff and then i can merge your branch
http://pastie.org/10302171

[NaWer]

I've just change the second newFileIcon to openFileIcon

[voldyman]

thanks!
merged, please verify so i can close the issue

[NaWer]

gtk-3.10 branch is running :)
I've just merge it to my master, updated with your last commits : icons on toolbar mode are still broken

[voldyman]

hmm, that is maybe because document-export & open-menu icons aren't in the default theme there. let me figure out a fix.

[NaWer]

After a quick look, my merge doesn't seems to be complete

[NaWer]

After another merge, I've got this (pushed in my master) :

better but not perfect.

Other issues (gtk 3.10 related ?) :

• close button in about dialog doesn't work...
• PDF export is broken : empty file (Export working bad #36)

[voldyman]

Close button issue is weird, I'll look into that. The PDF export thing is something that I can't reproduce, maybe you can help me fix it, do you use any language other than English in your system? The icon I think I'll need to bundle since it isn't present on ubuntu's default theme.

[NaWer]

I'll try my best but don't have much time currently.
I'm on Ubuntu 14.04 LTS in french.
The "gears" icons is here without toolbar :

[voldyman]

ok, fixed the icon issue in toolbar mode
can't reproduce the close button problem though

[NaWer]

Are you going to merge gtk-3.10 branch into master ?

[voldyman]

merged with master, please test 🔨

[NaWer]

It's running fine. I'll open a new bug for PDF and close button