Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Startup stucked on "update your browser" with recent Firefox ESR #714

Open
NicolasDumoulin opened this issue Dec 17, 2024 · 11 comments
Open

Startup stucked on "update your browser" with recent Firefox ESR #714

NicolasDumoulin opened this issue Dec 17, 2024 · 11 comments

Comments

@NicolasDumoulin
Copy link

Hi,
I've tested mosaico with the Dockerfile on my Ubuntu system.
But, when I'm trying the instance with my web browser Firefox version 128.5.2esr (Ubuntu 24.04), I got an alert "update your browser" that blocks the opening of any template.
Why?
Thanks
@bago
Copy link
Member

bago commented Dec 17, 2024

Can you open this page with your Firefox and report here the content of the text area?
https://mosaico.io/controlloalterazioni.html

@NicolasDumoulin
Copy link
Author

NicolasDumoulin commented Dec 17, 2024 •
edited
Loading 

OK

---------------------
<!DOCTYPE html>
<html><head><title>A</title>
</head>
<body><p style="color: red;" align="right" data-bind="style: { color: 'red' }">B</p><div data-bind="text: content">dummy content</div>

</body></html>

Firefox 128.5.2esr (without extensions)

@NicolasDumoulin
Copy link
Author

NicolasDumoulin commented Dec 17, 2024 •
edited
Loading

And with the flatpak version 133.0.3 (without extensions)

OK

---------------------
<!DOCTYPE html>
<html><head><title>A</title>
</head>
<body><p style="color: red;" align="right" data-bind="style: { color: 'red' }">B</p><div data-bind="text: content">dummy content</div>

</body></html>

@bago
Copy link
Member

bago commented Dec 17, 2024

I received a previous notification with a "PROBLEMA": the issue was there. One of your extension is altering iframes contents in a way that would break mosaico so you get that alert.

I guess when you disable extensions (the one that introduce the darkreader html/css content) Mosaico will stop complaining.

@NicolasDumoulin
Copy link
Author

You're right, the "PROBLEMA:" was due to one of my extensions. But I'd tested before with another profile without extensions.
The bug persists without extensions (ESR and flatpak version with empty profile) :-(
Thanks

@bago
Copy link
Member

bago commented Dec 17, 2024

You may try opening the javascript console and running "Mosaico.isCompatible(true);" and you should see a specific exception.

Here are the checks Mosaico makes:

mosaico/src/js/template-loader.js

Line 365 in f1321cc

var isCompatible = function(detailedException) {

Let me know.

@NicolasDumoulin
Copy link
Author

Here is the output:

Mosaico.isCompatible(true);
Missing required browser feature:  ES5 strict [template-loader.js:355](http://localhost:9006/rs/src/js/template-loader.js)
Uncaught Missing required browser feature: ES5 strict [template-loader.js:409](http://localhost:9006/rs/src/js/template-loader.js)
    isCompatible template-loader.js:409
    <anonyme> debugger eval code:1

@bago
Copy link
Member

bago commented Dec 17, 2024

I doubt your Firefox doens't support ES5 strict: maybe you have something broken in your build.

Do you get the incompatible browser error if you run mosaico demo at https://mosaico.io?

@NicolasDumoulin
Copy link
Author

The test "ES5 strict" on line 386 seems to work if the instruction "use strict" is uncommented.

@NicolasDumoulin
Copy link
Author

Do you get the incompatible browser error if you run mosaico demo at https://mosaico.io?

Indeed, it works with the instance demo.

I'd built my instance with:

git clone https://github.com/voidlabs/mosaico &&\
cd mosaico/ &&\
docker build -t mosaico/mosaico . &&\
docker run -p 9006:9006 mosaico/mosaico

@bago
Copy link
Member

bago commented Dec 19, 2024

I just tested with the same docker command sequence and Firefox ESR but I can't reproduce it.

Can you add here your built js, so I can compare it with the one generated here? http://127.0.0.1:9006/rs/mosaico.min.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bago @NicolasDumoulin