You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
because it's confusing to talk about "labeled as unlabeled", and by analogy with the "background" class used in object detection
define a constant in vak.constants like BACKGROUND_CLASS_NAME = 'background'
use that constant in all the functions that have it as a default, e.g. vak.labels.multi_char_labels has a skip default that currently is ('unlabeled',), rewrite as -> (constants.BACKGROUND_CLASS_NAME,)
also use in vak.labelset itself when we make the labelmap
The text was updated successfully, but these errors were encountered:
NickleDave
changed the title
rename 'unlabeled' to 'background'
rename 'unlabeled_label' -> 'unlabeled_class'; define as constant and use constant for default args
Feb 24, 2023
Thinking about this more.
The thing is that "unlabeled" is the more precise name.
When we use it, it's because we specifically care about segments left unlabeled when annotation a sequence of segments.
But I agree with myself that
unlabeled_label is a confusing variable name, should be renamed unlabeled_class
it would be better to have a constant and use that throughout the code base instead of having to find
because it's confusing to talk about "labeled as unlabeled", and by analogy with the "background" class used in object detection
vak.constants
like BACKGROUND_CLASS_NAME = 'background'vak.labels.multi_char_labels
has askip
default that currently is('unlabeled',)
, rewrite as ->(constants.BACKGROUND_CLASS_NAME,)
vak.labelset
itself when we make thelabelmap
The text was updated successfully, but these errors were encountered: