Implement map data sources for policy services and groups #1476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksamoray
force-pushed
the
list_data_sources
branch
from
818a5f5 to
191c280
Compare
|
/test-all |
annakhm
reviewed
Dec 5, 2024
ksamoray
force-pushed
the
list_data_sources
branch
2 times, most recently
from
873c26d to
7c7fde9
Compare
annakhm
changed the title
annakhm
changed the title
ksamoray
force-pushed
the
list_data_sources
branch
2 times, most recently
from
4a18c0a to
cc7c11d
Compare
ksamoray
changed the title
ksamoray
force-pushed
the
list_data_sources
branch
from
cc7c11d to
d32fcc4
Compare
ksamoray
force-pushed
the
list_data_sources
branch
from
d32fcc4 to
eae527e
Compare
|
/test-all |
ksamoray
force-pushed
the
list_data_sources
branch
from
eae527e to
d4a920d
Compare
|
/test-all |
annakhm
reviewed
Jan 16, 2025
| rule { | ||
| display_name = "allow_icmp" | ||
| destination_groups = [ | ||
| data.nsxt_policy_groups.test.items[index(data.nsxt_policy_groups.test.items.*.display_name, "Cats")].path, |
There was a problem hiding this comment.
I feel this syntax might be too complex to be widely adopted.. perhaps it would be more useful to offer just display_name=>path map.
ksamoray
force-pushed
the
list_data_sources
branch
2 times, most recently
from
16e9803 to
8922f49
Compare
|
/test-all |
ksamoray
force-pushed
the
list_data_sources
branch
3 times, most recently
from
6ae684c to
ee0d64a
Compare
annakhm
approved these changes
Jan 18, 2025
ksamoray
force-pushed
the
list_data_sources
branch
from
ee0d64a to
b007514
Compare
|
/test-all |
ksamoray
force-pushed
the
list_data_sources
branch
from
b007514 to
c95c348
Compare
|
/test-all |
3 similar comments
|
/test-all |
|
/test-all |
|
/test-all |
|
/test-all |
1 similar comment
|
/test-all |
ksamoray
force-pushed
the
list_data_sources
branch
from
c95c348 to
ff303aa
Compare
|
/test-all |
These data sources allows the retrieval of the entire tables from NSX to save multiple calls to the backend. Fixes: vmware#696 Signed-off-by: Kobi Samoray <[email protected]>
ksamoray
force-pushed
the
list_data_sources
branch
from
ff303aa to
06b59bf
Compare
|
/test-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These data sources allows the retrieval of the entire tables from NSX to save multiple calls to the backend.
Fixes: #696