Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use vro-scripting-api definitions instead of vro-types (Research) #351

Open
Michaelpalacce opened this issue Jul 22, 2024 · 5 comments
Open

Use vro-scripting-api definitions instead of vro-types (Research) #351

Michaelpalacce opened this issue Jul 22, 2024 · 5 comments
Labels
area/vro-scripting-api Relates to the vro-scripting-api module area/vro-types Relates to changes to the type definitions effort/high kind/research This task is a research task lang/typescript Related to typescript code priority/low triage/accepted The issue was accepted and will be done

Comments

@Michaelpalacce
Copy link
Collaborator

Michaelpalacce commented Jul 22, 2024 •
edited
Loading

Description

The definitions in vro-scriipting-api are duplicated in vro-types. Typescript will generate types based on the definitions in vro-scripting-api. The idea here is to do a POC if it's even possible to use the generated types from vro-scripting-api so we don't have duplicated logic.

Additional Context
@Michaelpalacce Michaelpalacce changed the title Placeholder: Use vro-scripting-api definitions instead of vro-types Placeholder: Use vro-scripting-api definitions instead of vro-types (Research) Jul 22, 2024
@Michaelpalacce Michaelpalacce mentioned this issue Jul 22, 2024
Open
@Michaelpalacce Michaelpalacce changed the title Placeholder: Use vro-scripting-api definitions instead of vro-types (Research) Use vro-scripting-api definitions instead of vro-types (Research) Jul 22, 2024
@Michaelpalacce Michaelpalacce added area/vro-types Relates to changes to the type definitions lang/typescript Related to typescript code area/vro-scripting-api Relates to the vro-scripting-api module priority/low effort/high kind/research This task is a research task triage/needed Needs to be discussed by project maintainers labels Jul 22, 2024
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Aug 22, 2024
@github-actions GitHub Actions
Copy link

This issue was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 29, 2024
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Sep 29, 2024
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Oct 31, 2024
@VenelinBakalov VenelinBakalov added triage/accepted The issue was accepted and will be done and removed triage/needed Needs to be discussed by project maintainers labels Nov 21, 2024
@VenelinBakalov
Copy link
Collaborator

Sync explicitly with @Michaelpalacce before starting work on this task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/vro-scripting-api Relates to the vro-scripting-api module area/vro-types Relates to changes to the type definitions effort/high kind/research This task is a research task lang/typescript Related to typescript code priority/low triage/accepted The issue was accepted and will be done
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Michaelpalacce @VenelinBakalov