Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

artifact-manager unit test code coverage increase #303

Open
Michaelpalacce opened this issue Jul 11, 2024 · 4 comments
Open

artifact-manager unit test code coverage increase #303

Michaelpalacce opened this issue Jul 11, 2024 · 4 comments
Labels
area/artifact-manager Relates to the `artifact-manager` maven module area/tests Relates to tests and code coverage kind/enhancement Enhancement or improvement of existing features lang/java Related to Java Code triage/accepted The issue was accepted and will be done triage/blocked This issue is blocked by another, specified in the description

Comments

@Michaelpalacce
Copy link
Collaborator

Disclaimer

Description

  • We need to increase the code coverage of the artifact-manager module
  • This task should contain multiple PRs for different components and not everything should be done at once
@Michaelpalacce Michaelpalacce added lang/java Related to Java Code area/artifact-manager Relates to the `artifact-manager` maven module area/tests Relates to tests and code coverage triage/blocked This issue is blocked by another, specified in the description kind/enhancement Enhancement or improvement of existing features labels Jul 11, 2024
@VenelinBakalov
Copy link
Collaborator

No longer blocked as #302 is implemented

@VenelinBakalov VenelinBakalov mentioned this issue Nov 1, 2024
Closed
@VenelinBakalov VenelinBakalov added triage/needed Needs to be discussed by project maintainers and removed triage/blocked This issue is blocked by another, specified in the description labels Nov 1, 2024
@VenelinBakalov
Copy link
Collaborator

Pending discussion on how to increase the coverage:

  • by targeting percentage
  • by targeting specific files/classes

@VenelinBakalov VenelinBakalov added the triage/blocked This issue is blocked by another, specified in the description label Nov 21, 2024
@VenelinBakalov
Copy link
Collaborator

Currently blocked by pending refactoring in #305

@VenelinBakalov
Copy link
Collaborator

After this is unblocked by the refactoring, next steps would be to:

  • go through all files and check which of them do NOT need unit testing (e.g. Models and so on) and add those files to be skipped with configuration (not sure if it is in-line comments or pom.xml configuration). This should passively increase the unit test coverage by a big amount
  • after the step above is done, we will add separate tasks for unit test coverage split by modules and/or products so that those tasks can easily be taken by members without overlap

@VenelinBakalov VenelinBakalov added triage/accepted The issue was accepted and will be done and removed triage/needed Needs to be discussed by project maintainers labels Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/artifact-manager Relates to the `artifact-manager` maven module area/tests Relates to tests and code coverage kind/enhancement Enhancement or improvement of existing features lang/java Related to Java Code triage/accepted The issue was accepted and will be done triage/blocked This issue is blocked by another, specified in the description
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Michaelpalacce @VenelinBakalov