You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
VM operator’s go mod indicates it leveraging go 1.18 but when running make lint-go-full I’m facing an error that indicates few dependencies versions are suitable for go 1.19
Steps to duplicate the issue :
Start a container with go 1.18 alpine :
docker run --name test-18 -it golang:1.18.0-alpine
Inside the docker run following cmds :
apk update
apk add --no-cache bash git make build-base
git clone https://github.com/vmware-tanzu/vm-operator.git
cd vm-operator
make lint-go-full
Output :
make -C hack/tools golangci-lint
make[1]: Entering directory '/go/vm-operator/hack/tools'
go build -tags=vmop_tools -o bin/golangci-lint github.com/golangci/golangci-lint/cmd/golangci-lint
go: downloading github.com/golangci/golangci-lint v1.51.2
go: downloading github.com/fatih/color v1.14.1
go: downloading github.com/gofrs/flock v0.8.1
.
.
.
go: downloading github.com/pelletier/go-toml v1.9.5
go: downloading github.com/mattn/go-runewidth v0.0.9
# honnef.co/go/tools/unused
/go/pkg/mod/honnef.co/go/[email protected]/unused/unused.go:419:14: obj.Origin undefined (type *types.Var has no field or method Origin)
/go/pkg/mod/honnef.co/go/[email protected]/unused/unused.go:421:14: obj.Origin undefined (type *types.Func has no field or method Origin)
note: module requires Go 1.19
# honnef.co/go/tools/staticcheck
/go/pkg/mod/honnef.co/go/[email protected]/staticcheck/lint.go:4025:29: righti.Method(i).Origin undefined (type *types.Func has no field or method Origin)
/go/pkg/mod/honnef.co/go/[email protected]/staticcheck/lint.go:4030:36: sel.Obj().(*types.Func).Origin undefined (type *types.Func has no field or method Origin)
note: module requires Go 1.19
make[1]: *** [Makefile:78: bin/golangci-lint] Error 2
make[1]: Leaving directory '/go/vm-operator/hack/tools'
make: *** [Makefile:181: hack/tools/bin/golangci-lint] Error 2
It passed for golang:1.20.0-alpine & golang:1.19.0-alpine
Go mod needs to be edited to indicate that we need to run go 1.19 or at-least those dependencies needs to be downgraded.
The text was updated successfully, but these errors were encountered:
VM operator’s go mod indicates it leveraging go 1.18 but when running make lint-go-full I’m facing an error that indicates few dependencies versions are suitable for go 1.19
Steps to duplicate the issue :
Output :
It passed for
golang:1.20.0-alpine
&golang:1.19.0-alpine
Go mod needs to be edited to indicate that we need to run go 1.19 or at-least those dependencies needs to be downgraded.
The text was updated successfully, but these errors were encountered: