Fix velero command examples #259
Open
+7
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Feilian Xie <[email protected]>
|
I see 5 more occurrences of AZURE_STORAGE_ACCOUNT_ID in the doc, can you also change them to NAME |
anshulahuja98
requested changes
Nov 6, 2024
| @@ -493,7 +493,7 @@ velero install \ | |||
| --plugins velero/velero-plugin-for-microsoft-azure:v1.11.0 \ | |||
| --bucket $BLOB_CONTAINER \ | |||
| --secret-file ./credentials-velero \ | |||
| --backup-location-config useAAD="true",resourceGroup=$AZURE_BACKUP_RESOURCE_GROUP,storageAccount=$AZURE_STORAGE_ACCOUNT_ID[,subscriptionId=$AZURE_BACKUP_SUBSCRIPTION_ID] \ | |||
There was a problem hiding this comment.
There are few more places where it is still AZURE_STORAGE_ACCOUNT_ID
Around line 119 and other places. please change those also
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The storageAccount key passed to the velero install --backup-location-config argument should contain the storage account name, not the storage account ID.