Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to graphql testing doc #203

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

marckhouzam
Copy link
Contributor

What this PR does / why we need it

This PR updates the README for the graphql testing framework as well as some comments here and there.

Also it fixes two error situations where the mock server would send more than one response because of the use of break instead of return.

Which issue(s) this PR fixes

Fixes # N/A

Describe testing done for PR

CI

Release note

Update graphql testing README.

Additional information

Special notes for your reviewer

Also fix two error situations where the mock server would send more than
one response.

Signed-off-by: Marc Khouzam <[email protected]>
@marckhouzam marckhouzam requested a review from a team as a code owner August 6, 2024 19:00
Copy link
Contributor

@anujc25 anujc25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 🎉

@marckhouzam marckhouzam merged commit 74c1c29 into vmware-tanzu:main Aug 6, 2024
5 checks passed
@marckhouzam marckhouzam deleted the fix/graphQLSub branch August 6, 2024 20:02
anujc25 pushed a commit to anujc25/tanzu-plugin-runtime that referenced this pull request Aug 8, 2024
Also fix two error situations where the mock server would send more than
one response.

Signed-off-by: Marc Khouzam <[email protected]>
@marckhouzam marckhouzam added this to the v1.4.2 milestone Aug 8, 2024
anujc25 pushed a commit that referenced this pull request Aug 8, 2024
Also fix two error situations where the mock server would send more than
one response.

Signed-off-by: Marc Khouzam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants