Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

golangci-lint fails with go 1.20 #240

Open
marckhouzam opened this issue Apr 30, 2023 · 0 comments
Open

golangci-lint fails with go 1.20 #240

marckhouzam opened this issue Apr 30, 2023 · 0 comments
Labels
kind/bug PR/issue related to a bug needs-triage

Comments

@marckhouzam
Copy link
Contributor

marckhouzam commented Apr 30, 2023 •
edited
Loading

Bug description

When using go 1.20 and running make lint, golangci-lint fails with a large amount of errors.
But a newer version of the tools passes with some minor changes to the tanzu-cli repo.

Expected behavior

No linting error with go 1.20 (and 1.19 and 1.18)

Steps to reproduce the bug / Relevant debug output

Use go 1.20:

$ go version
go version go1.20.3 darwin/arm64
$ make lint

Output of tanzu version

On the current main: bf4426738

Environment where the bug was observed (cloud, OS, etc)

Locally
@marckhouzam marckhouzam added kind/bug PR/issue related to a bug needs-triage labels Apr 30, 2023
@marckhouzam marckhouzam mentioned this issue Apr 30, 2023
Closed
marckhouzam added a commit to marckhouzam/tanzu-cli that referenced this issue Apr 30, 2023
@marckhouzam
Update golangci-lint for go 1.20
fa2c943 
Fixes vmware-tanzu#240

Note that "allow-leading-space" is no longer supported as mentioned in
golangci/golangci-lint#3063 (comment)

Fix new warnings that are now reported.

Signed-off-by: Marc Khouzam <[email protected]>
marckhouzam added a commit to marckhouzam/tanzu-cli that referenced this issue May 1, 2023
@marckhouzam
Update golangci-lint for go 1.20
a28c67f 
Fixes vmware-tanzu#240

Note that "allow-leading-space" is no longer supported as mentioned in
golangci/golangci-lint#3063 (comment)

Fix new warnings that are now reported.

Signed-off-by: Marc Khouzam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug PR/issue related to a bug needs-triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update golangci-lint for go 1.20 marckhouzam/tanzu-cli
2 participants
@marckhouzam and others