Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tail seems to fail if workload name includes . char #663

Open
2 tasks done
heyjcollins opened this issue Oct 20, 2023 · 0 comments
Open
2 tasks done

tail seems to fail if workload name includes . char #663

heyjcollins opened this issue Oct 20, 2023 · 0 comments
Labels
accepted bug Something isn't working MIGRATED-MIGRATED Migrated to private repo
Milestone

Comments

@heyjcollins
Copy link
Contributor

heyjcollins commented Oct 20, 2023

  • I reviewed open and closed Github issues that may be related to my problem.
  • I am reporting a bug that others will be able to reproduce.

Describe the bug

tanzu apps workload tail throws an error if there are periods ('.') in the workload name

$ tanzu apps workload tail -n official ucp.ucp-package.lever-v2 --timestamp --since 1h --verbose 10
Usage:
  tanzu apps workload tail <name> [flags]

Examples:
  tanzu apps workload tail my-workload
tanzu apps workload tail my-workload --since 1h

Flags:
      --component name   workload component name (e.g. build)
  -h, --help             help for tail
  -n, --namespace name   kubernetes namespace (defaulted from kube config)
      --since duration   time duration to start reading logs from (default 1m0s)
  -t, --timestamp        print timestamp for each log line

Global Flags:
      --context name      name of the kubeconfig context to use (default is current-context defined by kubeconfig)
      --kubeconfig file   kubeconfig file (default is $HOME/.kube/config)
      --no-color          deactivate color, bold, and emoji output
  -v, --verbose int32     number for the log level verbosity (default 1)

Error: name: Invalid value: "ucp.ucp-package.lever-v2"

NOTE: Let's keep this validation in place for tanzu apps workload create/apply... but remove it for all other tanzu apps workload... sub-commands.

Expected behavior

The tail command should...tail the logs successfully

Steps to Reproduce

  1. use kubectl to create a workload with a period in the name, e.g. workload.name
  2. run tanzu apps workload tail workload.name --timestamp --since 1h

Screenshots

If applicable, add screenshots to help explain your proble

@heyjcollins heyjcollins added bug Something isn't working needs-triage labels Oct 20, 2023
@heyjcollins heyjcollins added this to the 0.14.0 milestone Nov 21, 2023
@heyjcollins heyjcollins added the MIGRATED-MIGRATED Migrated to private repo label Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted bug Something isn't working MIGRATED-MIGRATED Migrated to private repo
Projects
None yet
Development

No branches or pull requests

2 participants