Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inaccurate warning about LDAP bind password being in ldap.yml #458

Open
coffee-squirrel opened this issue Nov 20, 2023 · 1 comment
Open

Comments

@coffee-squirrel
Copy link

coffee-squirrel commented Nov 20, 2023

Describe the bug
As of 1.0.72, and including 1.0.73, we see output like the following with every cf-mgmt command in our pipeline (delete-orgs, update-org-users, update-space-users, etc.):

2023/11/20 16:57:34 W1120 16:57:34.799654 20 yaml_config.go:542] Ldap bind password should be removed from ldap.yml as this will be deprecated in a future release.  Use --ldap-password flag instead.

This output does not show up in 1.0.71 or older.

We pass in the LDAP password via the LDAP_PASSWORD environment variable, and don't have anything in our ldap.yml for that value.

Probably related to #449, which appears to have touched some LDAP-related stuff.

To Reproduce
Steps to reproduce the behavior:

  1. Have a working LDAP config (LDAP_PASSWORD env var, the rest in ldap.yml) and have LOG_LEVEL=info.
  2. Run a command (e.g. cf-mgmt update-space-users) using cf-mgmt 1.0.71 or older and note the warning doesn't appear
  3. Run a command (e.g. cf-mgmt update-space-users) using cf-mgmt 1.0.72 or newer and note the warning appears

Expected behavior
The warning about having the LDAP bind password in ldap.yml should only occur if the property actually exists in ldap.yml.

@cf-gitbot
Copy link
Collaborator

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants