Fix ravager axe not properly proccing deep wounds, weapon enchants et…

[scottnice]

🍰 Pullrequest

Fix ravager axe not properly proccing deep wounds, weapon enchants etc on bladestorm hits, fixed ravager axe issue where channeling would stop when target died, extra attacks generated while channeling will now be applied after channelling is complete, this matches behaviour of classic. Fix issue with ravager bladestorm where its whirlwind hits could not reproc blade storm.

Proof

Windfury procs during bladestorm are stored and released after channelling is complete:
https://www.wowhead.com/classic/item=7717/ravager#comments:id=3160508
https://www.youtube.com/watch?v=XEZpNdxlV1A

Issues

• fixes Ravager Axe🐛 [Bug] #1786

How2Test

Create a character with ravager on a shaman and a warrior. Test with windfury and sweeping strikes.
Ravager whirlwind procs also do not consume sweeping strikes matching the functionality in the linked youtube video from Classic SoM

Todo / Checklist

• Fix bladestorm and sweeping strikes
• Fix White space issues

[Wall-core]

the spell_template data is taken directly from the client dbc and is blizzlike. If absolutely necessary, this would be handled under spell_effect_mod or spell_mod but would be better resolved in the core as it's best to avoid adding mods.

[scottnice]

Thanks Wall, I'll update it to use the spell_mod table for now but I'll also look to see if there's a way to handle this in the core.

[scottnice]

@Wall-core @ratkosrb it's possible the fields changed between versions. Because according to this commit 3f91713 at one point the bladestorm ability had the SPELL_ATTR_EX2_TRIGGERED_CAN_TRIGGER_PROC flag set, and this behavior has now moved over to the SPELL_ATTR_EX3_NOT_A_PROC flag which is not set on these spells. If the same migration in the code happened in the database one would expect the SPELL_ATTR_EX3_NOT_A_PROC flag to be set on the Bladestorm and its Whirlwind proc.

[ratkosrb]

Both the attributes assigned to spells you see in spell_template, and the naming of attributes in the source code comes from Blizzard. None of these should be changed.

[scottnice]

@Wall-core @ratkosrb Updated to use spell_mod table and made some small code changes to support proper functioning of Ravager without impacting other abilities.

[scottnice]

@ratkosrb some of this code can be replaced with overrides via the spell mod table. Let me know which path you prefer and I can update the pull request accordingly.