Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Langues Bug Fixed #355

Open
HakanKorkz opened this issue Apr 19, 2022 · 4 comments
Open

Langues Bug Fixed #355

HakanKorkz opened this issue Apr 19, 2022 · 4 comments

Comments

@HakanKorkz
Copy link

Fixing the language bug in the Valitron package

The automatic Composer installation of this package works without any problems, but when the package files are downloaded to the computer in ZIP form, unzipped and included in the project, a language bug occurs as seen in the image below.

In the picture I posted, the bug is fixed on the 118th line.

I am posting the solution to the language bug here in the Valitron package.

Error: https://imgur.com/BKyKCSS

Error: https://imgur.com/wtlDFbL

Success: https://imgur.com/i85MW2V

Finish: https://imgur.com/mGqPOSR

@joebordes
Copy link
Contributor

related to #247?

@willemwollebrants
Copy link
Collaborator

I'm a bit confused at the code in https://imgur.com/wtlDFbL, why is /Validator.php in there? The code in https://imgur.com/i85MW2V seems correct and the same as it is in the repo right now

@HakanKorkz
Copy link
Author

related to #247?

Yes

@HakanKorkz
Copy link
Author

I'm a bit confused at the code in https://imgur.com/wtlDFbL, why is /Validator.php in there? The code in https://imgur.com/i85MW2V seems correct and the same as it is in the repo right now

Unfortunately, the bug in the repo is now a manual install bug https://imgur.com/i85MW2V the bug in this link is on line 113.

@HakanKorkz HakanKorkz reopened this Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants