Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Make outlines dependency optional #3794

Closed
saattrupdan opened this issue Apr 2, 2024 · 7 comments · Fixed by #10576
Closed

[Feature]: Make outlines dependency optional #3794

saattrupdan opened this issue Apr 2, 2024 · 7 comments · Fixed by #10576

Comments

@saattrupdan
Copy link

saattrupdan commented Apr 2, 2024

🚀 The feature, motivation and pitch

I'm using a newer version of outlines than v0.0.34, and my application needs the fixes implemented in newer versions of that package. It would be great if vllm could make its structured generation dependencies optional, as I'm not using the internal vllm structured generation, but rather using the logits processors from outlines directly.

Alternatives

No response

Additional context

This prevents me from updating to vllm==0.4.0.

@simon-mo
Copy link
Collaborator

simon-mo commented Apr 2, 2024

Alternatively we can relax the outlines version to not to pin it or set it >=v0.0.34. That will be an even easier fix at the moment :D.

Once we have multiple guided decoding backends I think the packages can be optional.

@saattrupdan
Copy link
Author

saattrupdan commented Apr 3, 2024

Alternatively we can relax the outlines version to not to pin it or set it >=v0.0.34. That will be an even easier fix at the moment :D.

That could work! However, note that some of the imports from outlines (RegexFSM for instance) is currently deprecated and will be removed in June, causing ImportErrors in vLLM if nothing changes. But it would at least work until then :)

A quick hotfix could maybe be to relax the versioning and move the outlines imports in guided_logits_processors.py into the classes, to avoid problems if you aren't using that module?

@simon-mo
Copy link
Collaborator

simon-mo commented Apr 3, 2024

The update ticket: #3715

Copy link

This issue has been automatically marked as stale because it has not had any activity within 90 days. It will be automatically closed if no further activity occurs within 30 days. Leave a comment if you feel this issue should remain open. Thank you!

@github-actions github-actions bot added the stale label Oct 29, 2024
@saattrupdan
Copy link
Author

@simon-mo An upper bound on outlines was re-introduced in #6262, and I am relying on newer outlines versions. Since I don't use the vllm-outlines integration at all (I just use the logits processors from outlines), I'd raise my initial question again: Can we please make the outlines dependency of vLLM optional?

@github-actions github-actions bot added unstale and removed stale labels Nov 15, 2024
@chris-aeviator
Copy link

@simon-mo An upper bound on outlines was re-introduced in #6262, and I am relying on newer outlines versions. Since I don't use the vllm-outlines integration at all (I just use the logits processors from outlines), I'd raise my initial question again: Can we please make the outlines dependency of vLLM optional?

can't agree more - using this antique version of outlines breaks all my dependency management. This should be discouraged within vllm PR reviews.

@mgoin
Copy link
Member

mgoin commented Dec 6, 2024

We will support the latest versions of outlines with this PR #10576

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants