You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The VllmConfig becomes huge as more and more features are added in vLLM. But some of that I think is immutable to users, thus not suitable to be as a configure, e.g. worker_cls, and other private args.
Inspired by this comment from Nick, I think creating a dataclass VllmState could help making VllmConfig lighter and safer for users to specify.
Proposed Change.
I think VllmState is similar to VllmConfig, composed by similar member vars as VllmConfig.
And the initial member of VllmState will absorb the immutable args of the corresponding members in VllmConfig as its member variables. And in the meantime, xxxConfig will also be a member of xxxState.
VllmState will be constructed at the begining of the initialize of LLMEngine, and we could just use vllm_state as argument for executor/worker/model_runner/model. Maybe other modules are missing, plz help me add if you know it
I'm sorting out the immutable vars of all the xxxConfig, I'll update this info in a table later. And there is a tiny example for ParallelState:
@dataclassclassParallelState:
parallel_config: ParallelConfigplacement_group: Optional["PlacementGroup"]
worker_cls: strworld_size: intrank: int
There are quite a lot args in VllmConfig, and only a few are marked as private. Is there any other way for me to find out the immutable member vars for users in VllmConfig? Or you can just post the vars you think should put into VllmState here. Thanks!
Before submitting a new issue...
Make sure you already searched for relevant issues, and asked the chatbot living at the bottom right corner of the documentation page, which can answer lots of frequently asked questions.
The text was updated successfully, but these errors were encountered:
Motivation.
The
VllmConfig
becomes huge as more and more features are added in vLLM. But some of that I think is immutable to users, thus not suitable to be as a configure, e.g.worker_cls
, and other private args.Inspired by this comment from Nick, I think creating a dataclass
VllmState
could help makingVllmConfig
lighter and safer for users to specify.Proposed Change.
I think
VllmState
is similar toVllmConfig
, composed by similar member vars asVllmConfig
.And the initial member of
VllmState
will absorb the immutable args of the corresponding members inVllmConfig
as its member variables. And in the meantime,xxxConfig
will also be a member ofxxxState
.VllmState
will be constructed at the begining of the initialize ofLLMEngine
, and we could just use vllm_state as argument for executor/worker/model_runner/model.Maybe other modules are missing, plz help me add if you know it
I'm sorting out the immutable vars of all the
xxxConfig
, I'll update this info in a table later. And there is a tiny example forParallelState
:Feedback Period.
No response
CC List.
cc @youkaichao @njhill @WoosukKwon @DarkLight1337
Any Other Things.
[Help wanted]
There are quite a lot args in
VllmConfig
, and only a few are marked as private. Is there any other way for me to find out the immutable member vars for users inVllmConfig
? Or you can just post the vars you think should put intoVllmState
here. Thanks!Before submitting a new issue...
The text was updated successfully, but these errors were encountered: