Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V error when trying to get shared array slice inside rlock { ... } #23426

Closed
islonely opened this issue Jan 10, 2025 · 0 comments · Fixed by #23427
Closed

V error when trying to get shared array slice inside rlock { ... } #23426

islonely opened this issue Jan 10, 2025 · 0 comments · Fixed by #23427
Assignees
Labels
Bug This tag is applied to issues which reports bugs. Status: Confirmed This bug has been confirmed to be valid by a contributor. Unit: cgen Bugs/feature requests, that are related to the default C generating backend.

Comments

@islonely
Copy link
Contributor

islonely commented Jan 10, 2025

V version: V 0.4.9 36154b8, press to see full `v doctor` output
V full version V 0.4.9 4225a34.36154b8
OS macos, macOS, 15.1.1, 24B91
Processor 8 cpus, 64bit, little endian, Apple M3
Memory 0.25GB/16GB
V executable /Users/adamoates/v/v
V last modified time 2025-01-10 18:21:11
V home dir OK, value: /Users/adamoates/v
VMODULES OK, value: /Users/adamoates/.vmodules
VTMP OK, value: /tmp/v_501
Current working dir OK, value: /Users/adamoates/Documents/shattlebip
Git version git version 2.39.5 (Apple Git-154)
V git status weekly.2025.1-27-g36154b86
.git/config present true
cc version Apple clang version 16.0.0 (clang-1600.0.26.4)
gcc version Apple clang version 16.0.0 (clang-1600.0.26.4)
clang version Apple clang version 16.0.0 (clang-1600.0.26.4)
tcc version tcc version 0.9.28rc 2024-02-05 HEAD@105d70f7 (AArch64 Darwin)
tcc git status thirdparty-macos-arm64 713692d4
emcc version N/A
glibc version N/A

What did you do?
./v -g -o vdbg cmd/v && ./vdbg /Users/adamoates/Documents/test.v && /Users/adamoates/Documents/test

struct Foo {
pub mut:
	buf shared []u8
}

fn main() {
	mut foo := Foo{}
	rlock foo.buf {
		if foo.buf.len > 0 {
			x := 10
			println('first ${x} bytes: ' + foo.buf[..x].str())
		} else {
			println('no data')
		}
	}
}

What did you see?

/Users/adamoates/Documents/test.v:11:39: error: you have to create a handle and `rlock` it to use a `shared` element as non-mut receiver
    9 |         if foo.buf.len > 0 {
   10 |             x := 10
   11 |             println('first ${x} bytes: ' + foo.buf[..x].str())
      |                                                ~~~~~~~~
   12 |         } else {
   13 |             println('no data')
/Users/adamoates/Documents/test.v:11:39: error: you have to create a handle and `rlock` it to use a `shared` element as non-mut argument to print
    9 |         if foo.buf.len > 0 {
   10 |             x := 10
   11 |             println('first ${x} bytes: ' + foo.buf[..x].str())
      |                                                ~~~~~~~~
   12 |         } else {
   13 |             println('no data')

What did you expect to see?

Expected code to compile.

Note

You can use the 👍 reaction to increase the issue's priority for developers.

Please note that only the 👍 reaction to the issue itself counts as a vote.
Other reactions and those to comments will not be taken into account.

@felipensp felipensp self-assigned this Jan 10, 2025
@felipensp felipensp added Bug This tag is applied to issues which reports bugs. Status: Confirmed This bug has been confirmed to be valid by a contributor. Unit: cgen Bugs/feature requests, that are related to the default C generating backend. labels Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This tag is applied to issues which reports bugs. Status: Confirmed This bug has been confirmed to be valid by a contributor. Unit: cgen Bugs/feature requests, that are related to the default C generating backend.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants