New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIXME]: remove concatenation out of loop #5

Open

vkhodygo opened this issue Mar 26, 2021 · 0 comments

Labels

Owner

vkhodygo commented Mar 26, 2021

Reading file involves concatenation at

am_tools/am_tools/modules/giant_density_fluctuations.py

Line 70 in 643953a

df_ = concat([df_, x], ignore_index=True)

That behaviour is undesired as discussed here: 1 and 2 (see also this discussion).

vkhodygo added enhancement performance and removed enhancement labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment