Skip to content

Commit

Permalink
Merge pull request #1234 from vivliostyle/fix/issue1233
Browse files Browse the repository at this point in the history
fix: page breaking inside table may cause unexpected page type reset
  • Loading branch information
MurakamiShinyu authored Nov 6, 2023
2 parents 0d64885 + 59929ea commit 682af21
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions packages/core/src/vivliostyle/vgen.ts
Original file line number Diff line number Diff line change
Expand Up @@ -959,6 +959,14 @@ export class ViewFactory
const pageVal: Css.Val = computedStyle["page"];
let pageType =
pageVal && !Css.isDefaultingValue(pageVal) && pageVal.toString();
if (
!pageType &&
!this.nodeContext.parent &&
this.nodeContext.shadowContext
) {
// Keep currentPageType for shadowContext (Fix for issue #1233)
pageType = this.styler.cascade.currentPageType;
}
if (!pageType || pageType.toLowerCase() === "auto") {
pageType = this.nodeContext.pageType;
} else {
Expand Down

1 comment on commit 682af21

@vercel
Copy link

@vercel vercel bot commented on 682af21 Nov 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

vivliostyle – ./

vivliostyle-git-master-vivliostyle.vercel.app
vivliostyle-vivliostyle.vercel.app
vivliostyle.vercel.app

Please sign in to comment.