Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Embedded YouTube Iframes #47

Open
garrett-hopper opened this issue May 19, 2023 · 3 comments
Open

Support Embedded YouTube Iframes #47

garrett-hopper opened this issue May 19, 2023 · 3 comments

Comments

@garrett-hopper
Copy link

No description provided.

@vityevato
Copy link
Owner

@garrett-hopper screenshort please, what you meant

@vityevato
Copy link
Owner

vityevato commented May 19, 2023 •
edited
Loading

Insertion in other sites?

@garrett-hopper
Copy link
Author

Yeah, sorry for not clarifying.
Embedded YouTube videos are not currently controllable.

I attempted to modify the YouTube bsstrategy to have format: "(%K LIKE[c] '*youtube.com/watch*' || %K LIKE[c] '*youtube.com/embed*') && !%@ LIKE[c] '*music.youtube.com*'",, however it's not run in the iframe.
I also tried editing the Chrome extension to remove the window != window.top check, however that didn't appear to change anything.

In particular I'm viewing YouTube videos in Readwise Reader where they are popped out to view as picture in picture. I'm also testing using Arc browser (using the Chrome extension).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vityevato @garrett-hopper