Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use state validation in state-based change derivation tests #516

Open
JanWittler opened this issue Apr 20, 2022 · 0 comments
Open

Use state validation in state-based change derivation tests #516

JanWittler opened this issue Apr 20, 2022 · 0 comments

Comments

@JanWittler
Copy link
Contributor

Currently, the state-based change derivation tests in tools.vitruv.framework.views.changederivation validate the correctness of the derived changes by comparing the derived changes to the recorded ones. This is a too strong constraint as we cannot expect the change derivation to yield the exact change sequence in any case. Rather, we should validate the final state of the resource after applying the derived changes. In addition, in some test cases it might be reasonable to expect certain characteristics from the change sequence, like a correct semantic ordering (contained elements are created after their container) or the absence / presence of a certain change operation type (like element creation / deletion).

Some tests already use state validation but rely on EMF Compare to validate the state. As the change derivation strategy currently also uses EMF Compare, we should consider switching to another validation mechanic as the validation of a tool with itself can easily result in missing errors.

For further discussion, see #515.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant