Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

valet share command needs support for ngrok -subdomain and -region params #14

Open
leonardoamx opened this issue Nov 15, 2018 · 1 comment
Assignees

Comments

@leonardoamx
Copy link

In Unix, you can type valet share [-subdomain=project] [-region=us] to define a custom url (project.ngrok.io or project.us.ngrok.io) but this package has valet share with no params.

Code https://github.com/vitr/valet4windows/blob/a0126b94be10e302f6c2cb5965c70f40a53329df/cli/valet.php#L58

@leonardoamx leonardoamx changed the title Support needes for ngrok -subdomain and -region params for valet share command valet share command needs support for ngrok -subdomain and -region params Nov 15, 2018
@vitr
Copy link
Collaborator

vitr commented Nov 16, 2018

I'm not using valet anymore, as I switched to docker years ago (life is so much easier now)), but you're welcome to submit a fix, as I understand this might be a help to someone. cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants