Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect height of scrolling element after reinitialization. #351

Open
alexeylepesin opened this issue Jan 24, 2018 · 18 comments
Open

Incorrect height of scrolling element after reinitialization. #351

alexeylepesin opened this issue Jan 24, 2018 · 18 comments

Comments

@alexeylepesin
Copy link

elem.width(paneWidth);

Please move line 185 to 162

@illuusio
Copy link
Collaborator

Please make more informative why I should do that or PR with more description

@alexeylepesin
Copy link
Author

Hello.
I'm sorry, I had in mind the line 184 (pane.css ('width', '');) should be placed to line 162

pane.css('width', '');

In this case, the element will again have the same dimensions as before the initialization.

@illuusio
Copy link
Collaborator

Is there possibility to make PR so I can see all needed actions and some test case?

@illuusio
Copy link
Collaborator

illuusio commented Feb 3, 2018

Actually it's all ready done in line 156 and line 184 should be removed altogether.

@alexeylepesin
Copy link
Author

Hello, sorry, I did not answer for a long time.

TEST CASE (tested on google chrome):
https://jsfiddle.net/0bmjz0zs/6/
1. click on "Run scroller"
  the width of the .jspPane element 356px
   table width 354px

2. delete one or more columns by clicking on the "Remove a column"

3. click on "Update scroller"
  the width of the .jspPane element has not changed and is still 356px
   table width after removing 1 column 284px, after removing 2 columns - 214px

The width of the .jspPane must match the width of the table.
I'm a bit inaccurate in describing the problem. I am using your library in my application twice: for the BODY element and for the container for TABLE. After manipulating TABLE and reinitializing both scrollers, the height of the BODY element has an incorrect height, although the cause is in the wrong width of the container for TABLE.

@illuusio
Copy link
Collaborator

Thank you very much! excellent example. I take a look at this.

@alexeylepesin
Copy link
Author

You are welcome.
I'm not strong in English, could you explain what the PR means?

@illuusio
Copy link
Collaborator

Sorry it's PR is Pull Request.

@alexeylepesin
Copy link
Author

Thanks

@pgroot91
Copy link

pgroot91 commented Sep 29, 2018

I have a simular issue with de height of the container when implementing live search when rows disappear! Any ideas on how to fix this?

@illuusio
Copy link
Collaborator

As my time is limited you can audit that test case if it's the same as yours. If it's not you can submit small example how you example is different

@illuusio
Copy link
Collaborator

Have new version made any progress on this?

@RajuTicvic
Copy link

Hello @vitch ,
I'm using your jsscrollpane, it is very useful to me. i struck in one place so please help me FIX IT.
i want table header fixed when scroll vertically and when i scroll horizontal it will be better work as normal scroller .
scr1

@illuusio
Copy link
Collaborator

illuusio commented Jun 24, 2019

@RajuTicvic does commented fix your situation?

@RajuTicvic
Copy link

Which comments

@illuusio
Copy link
Collaborator

This first one which @alexeylepesin tells you to change place in code or is your problem a new Issue?

@RajuTicvic
Copy link

No

@illuusio
Copy link
Collaborator

@RajuTicvic Actually your request doesn't have anything to do with jScrollPane as it's purpose is only to 'skin' your scrollbars not alter how HTML tables work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants