Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

does not work with jquery validation? #60

Open
jinfang1234 opened this issue Jul 1, 2016 · 2 comments · May be fixed by #65
Open

does not work with jquery validation? #60

jinfang1234 opened this issue Jul 1, 2016 · 2 comments · May be fixed by #65

Comments

@jinfang1234
Copy link

This plugin seems not working with the jquery validation. Below is an sample codes showing that validation does not take effect. Can you please advise?

http://jsfiddle.net/5m6gG/376/

Thanks!
Jin Fang
test1
@bipin244
Copy link

bipin244 commented Oct 26, 2016 •
edited
Loading

i think combodate is hidden fields and jquery validate by default ignore combodate so add
ignore: [],
in validate
example link is here :
[http://jsfiddle.net/5m6gG/439/]

@dnasir
Copy link

dnasir commented Nov 8, 2016

@bipin244 I don't think that's a good solution because there are situations where a field may be hidden because it's irrelevant to the current state of the form, and only becomes relevant based on the value of another field.

I propose using the .sr-only technique introduced in Bootstrap to hide the actual input field. This way the field will not be considered hidden by jQuery (the default ignore value is :hidden) and validation will kick in.

dnasir added a commit to dnasir/combodate that referenced this issue Nov 13, 2016
@dnasir
Implemented Bootstrap .sr-only CSS rule.
e1d8ac1 
* This should hide the original element without breaking jquery validation.
* Should fix vitalets#60.
@dnasir dnasir linked a pull request Nov 13, 2016 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implemented Bootstrap .sr-only CSS rule. dnasir/combodate
3 participants
@dnasir @bipin244 @jinfang1234