Unnecessary memory expansion?

[DanNBullock]

vistasoft/fileFilters/mrtrix/dtiImportFibersMrtrix.m

Line 103 in 8c402f9

fg.fibers=cellfun(@double, fg.fibers, 'UniformOutput', false);

Hypothetically speaking, if the streamline coordinates of the input fg are not in double precision float, doesn't this double the ram usage without any associated gain in precision?

Indeed, at this point (

vistasoft/fileFilters/mrtrix/dtiImportFibersMrtrix.m

Line 79 in 8c402f9

tmp = fread(fid,inf,'*float32')';

) its actually single point precision, so it seems that this is necessarily the case.

Also, even in cases where the input is in double point precision, is that level of precision actually useful given the diffusion resolutions we are typically working with?

Is this line necessary?

[soichih]

I've tested some algorithms (encode, LiFE) using fg without converting to double. The results were within expected stochasticity. We need to test it with more algorithms but so far it seems that we don't need to convert to double.