Add socket diagnosis for UDP #927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@srebhan This project follows a "1 commit per PR" approach. |
|
@aboch will squash the commits then. Thought you squash them on merge... |
srebhan
force-pushed
the
sock_diag_udp
branch
from
3cc37c1
to
804e141
Compare
|
@aboch or @vishvananda any feedback? Anything I can do to get this in? |
aboch
reviewed
Dec 4, 2023
aboch
reviewed
Dec 4, 2023
|
Can you see if possible to add or extend existing UT to cover this functionality? |
srebhan
force-pushed
the
sock_diag_udp
branch
2 times, most recently
from
a60170f
to
f085c72
Compare
srebhan
force-pushed
the
sock_diag_udp
branch
2 times, most recently
from
a7431e2
to
6f81931
Compare
|
@aboch any update on this PR? Anything I can do to make the merge happen? |
aboch
requested changes
Jan 8, 2024
|
please squash the two commits into one |
Signed-off-by: Sven Rebhan <[email protected]>
srebhan
force-pushed
the
sock_diag_udp
branch
from
603f797
to
69e6d64
Compare
|
@aboch done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds netlink socket diagnosis support for UDP and implements parsing of the
INET_DIAG_MEMINFOextension data.