change all ioutil calls to os #904
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh I just realized the autoformatting kicked in and added linebreaks on longer function calls. Let me know if this is a problem, then I will go back and change it. |
thaJeztah
reviewed
Sep 4, 2023
Comment on lines
+80
to
+84
| t.Errorf( | ||
| "expected MAC for first entry to be %s, got %s", | ||
| expectedMAC.String(), | ||
| ent.MAC.String(), | ||
| ) |
There was a problem hiding this comment.
I'm not a maintainer on this repo, but I'd prefer the changes to be reverted; keeping these lines as a single line makes it easier to "skimp" over them when reading the code ("we're returning an error"); breaking it up over multiple lines doesn't really improve readability, and introduces code-churn, which we should avoid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes all calls and imports of ioutils which is deprecated.
Only ReadFile and WriteFile of ioutil is used and those are just imported from os instead.
This is my first pull request on this branch, I don't know if you have some rules about how it should be done, please let me know if I need to do anything :-)